Bug 58074 - dump-as-markup conversion: editing/pasteboard/5065605.html and display-block-on-spans.html
Summary: dump-as-markup conversion: editing/pasteboard/5065605.html and display-block-...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 57743
  Show dependency treegraph
 
Reported: 2011-04-07 13:27 PDT by Ryosuke Niwa
Modified: 2011-04-08 00:53 PDT (History)
5 users (show)

See Also:


Attachments
converted the tests (40.32 KB, patch)
2011-04-07 13:59 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
removed extra script tags (39.95 KB, patch)
2011-04-07 14:01 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
58074 (39.96 KB, patch)
2011-04-07 14:06 PDT, Ryosuke Niwa
tony: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-04-07 13:27:26 PDT
The following tests should be converted to dump-as-markup / dump-as-text tests:
editing/pasteboard/5065605.html	expected
editing/pasteboard/display-block-on-spans.html
Comment 1 Ryosuke Niwa 2011-04-07 13:59:02 PDT
Created attachment 88690 [details]
converted the tests
Comment 2 Ryosuke Niwa 2011-04-07 14:01:41 PDT
Created attachment 88691 [details]
removed extra script tags
Comment 3 Ryosuke Niwa 2011-04-07 14:06:19 PDT
Created attachment 88693 [details]
58074
Comment 4 Tony Chang 2011-04-07 15:13:00 PDT
Comment on attachment 88693 [details]
58074

View in context: https://bugs.webkit.org/attachment.cgi?id=88693&action=review

> LayoutTests/editing/pasteboard/display-block-on-spans-expected.txt:4
> +The following two results must be visually identical.

Might want to note that they are identical except for the caret.

> LayoutTests/editing/pasteboard/display-block-on-spans-expected.txt:34
> +|     "This<#selection-caret>"
> +|   <b>
> +|     " is another paragraph."

FWIW, it's not as easy to tell that this is visually the same.  In particular, the  is confusing.
Comment 5 Ryosuke Niwa 2011-04-07 15:18:28 PDT
Comment on attachment 88693 [details]
58074

View in context: https://bugs.webkit.org/attachment.cgi?id=88693&action=review

Thanks for the review.

>> LayoutTests/editing/pasteboard/display-block-on-spans-expected.txt:4

> 
> Might want to note that they are identical except for the caret.

Good point.

>> LayoutTests/editing/pasteboard/display-block-on-spans-expected.txt:34
>> +|     " is another paragraph."
> 
> FWIW, it's not as easy to tell that this is visually the same.  In particular, the  is confusing.

Yeah, we should probably convert non-breaking spaces by &nbsp; in dump-as-markup.js.  That should be a separate patch though.  Hopefully, most of people are aware that it's nbsp.
Comment 6 Ryosuke Niwa 2011-04-08 00:53:25 PDT
Committed r83268: <http://trac.webkit.org/changeset/83268>