Bug 58074 – dump-as-markup conversion: editing/pasteboard/5065605.html and display-block-on-spans.html

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Ryosuke Niwa]

The following tests should be converted to dump-as-markup / dump-as-text tests:
editing/pasteboard/5065605.html	expected
editing/pasteboard/display-block-on-spans.html

[Ryosuke Niwa]

Created attachment 88690 [details]
converted the tests

[Ryosuke Niwa]

Created attachment 88691 [details]
removed extra script tags

[Ryosuke Niwa]

Created attachment 88693 [details]
58074

[Tony Chang]

Comment on attachment 88693 [details]
58074

View in context: https://bugs.webkit.org/attachment.cgi?id=88693&action=review

> LayoutTests/editing/pasteboard/display-block-on-spans-expected.txt:4
> +The following two results must be visually identical.

Might want to note that they are identical except for the caret.

> LayoutTests/editing/pasteboard/display-block-on-spans-expected.txt:34
> +|     "This<#selection-caret>"
> +|   <b>
> +|     " is another paragraph."

FWIW, it's not as easy to tell that this is visually the same.  In particular, the  is confusing.

[Ryosuke Niwa]

Comment on attachment 88693 [details]
58074

View in context: https://bugs.webkit.org/attachment.cgi?id=88693&action=review

Thanks for the review.

>> LayoutTests/editing/pasteboard/display-block-on-spans-expected.txt:4

> 
> Might want to note that they are identical except for the caret.

Good point.

>> LayoutTests/editing/pasteboard/display-block-on-spans-expected.txt:34
>> +|     " is another paragraph."
> 
> FWIW, it's not as easy to tell that this is visually the same.  In particular, the  is confusing.

Yeah, we should probably convert non-breaking spaces by   in dump-as-markup.js.  That should be a separate patch though.  Hopefully, most of people are aware that it's nbsp.

[Ryosuke Niwa]

Committed r83268: <http://trac.webkit.org/changeset/83268>