Bug 58073 – Presence of shadow DOM should suppress rendering of ordinary child nodes

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Dominic Cooney]

Created attachment 88680 [details]
Should just see keygen select (shadow), but "Hello world" also appears.

When an element has both ordinary children and shadow children, both appear. The presence of shadow children should suppress the rendering of ordinary children.

Repro'd in WK nightly: Version 5.0.4 (6533.20.27, r83161)

[Dimitri Glazkov (Google)]

(In reply to comment #0)
> Created an attachment (id=88680) [details]
> Should just see keygen select (shadow), but "Hello world" also appears.
> 
> When an element has both ordinary children and shadow children, both appear. The presence of shadow children should suppress the rendering of ordinary children.
> 
> Repro'd in WK nightly: Version 5.0.4 (6533.20.27, r83161)

The reduction is wrong (the parser is smart enough to move the text out to be a child of body), but the problem is still present. Fix coming up...

[Dimitri Glazkov (Google)]

Created attachment 89466 [details]
Patch

[Ojan Vafai]

Comment on attachment 89466 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89466&action=review

> Source/WebCore/dom/Node.cpp:855
> +inline static ContainerNode* shadowRoot(Node* node)

I don't think this inline is really needed. We should reserve inline for cases where we can actually show an improvement, no? But I'm a n00b so feel free to ignore this. :)

> Source/WebCore/dom/Node.cpp:1460
> +inline static bool shouldCreateRendererFor(Node* node, ContainerNode* parentForRenderingAndStyle)

ditto re: inline

[Dimitri Glazkov (Google)]

Created attachment 89475 [details]
Better patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 89475 [details]:

animations/suspend-resume-animation.html bug 48161 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 89475 [details]
Better patch.

Clearing flags on attachment: 89475

Committed r83922: <http://trac.webkit.org/changeset/83922>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.