Bug 58067 - Somehow about:blank gets into the icon database
Summary: Somehow about:blank gets into the icon database
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-07 12:13 PDT by Darin Adler
Modified: 2011-06-17 17:26 PDT (History)
3 users (show)

See Also:

Attachments
Patch (21.96 KB, patch)
2011-04-07 16:39 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (22.10 KB, patch)
2011-04-08 10:12 PDT, Darin Adler 		sam: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2011-04-07 12:13:03 PDT 
Somehow about:blank gets into the icon database
Comment 1 Darin Adler 2011-04-07 16:39:16 PDT 
Created attachment 88729 [details]
Patch
Comment 2 WebKit Review Bot 2011-04-07 17:52:33 PDT 
Attachment 88729 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8347795
Comment 3 WebKit Review Bot 2011-04-08 05:33:27 PDT 
Attachment 88729 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8344972
Comment 4 Darin Adler 2011-04-08 10:12:08 PDT 
Created attachment 88836 [details]
Patch
Comment 5 WebKit Commit Bot 2011-04-26 11:10:45 PDT 
Comment on attachment 88836 [details]
Patch

Rejecting attachment 88836 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-..." exit_code: 2

Last 500 characters of output:
RLGoogle.cpp
Hunk #3 succeeded at 196 (offset 5 lines).
Hunk #4 succeeded at 204 (offset 5 lines).
Hunk #5 succeeded at 258 (offset 5 lines).
Hunk #6 succeeded at 370 (offset 5 lines).
Hunk #7 succeeded at 443 (offset 5 lines).
Hunk #8 succeeded at 883 (offset 5 lines).
patching file Source/WebCore/platform/KURLGooglePrivate.h
Hunk #1 succeeded at 91 (offset 1 line).

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Sam Weinig', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/8505937
Comment 6 Darin Adler 2011-04-27 09:22:54 PDT 
Committed r85056: <http://trac.webkit.org/changeset/85056>
Comment 7 Andy Estes 2011-06-17 17:13:37 PDT 
Comment on attachment 88836 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88836&action=review

> Source/WebCore/platform/KURL.cpp:705
> +        if (!protocol[i] || !isLetterMatchIgnoringCase(m_string[i], protocol[i]))

This is wrong for protocolIs(), since protocols can have non-letter characters (numbers, '+', '-' and '.') but isLetterMatchIgnoringCase() ASSERTs when the second-argument is not lowercase 'a' through 'z'.
Comment 8 Darin Adler 2011-06-17 17:26:04 PDT 
(In reply to comment #7)
> (From update of attachment 88836 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=88836&action=review
> 
> > Source/WebCore/platform/KURL.cpp:705
> > +        if (!protocol[i] || !isLetterMatchIgnoringCase(m_string[i], protocol[i]))
> 
> This is wrong for protocolIs(), since protocols can have non-letter characters (numbers, '+', '-' and '.') but isLetterMatchIgnoringCase() ASSERTs when the second-argument is not lowercase 'a' through 'z'.

The protocolIs function works only for protocols that are all letters. Dave Kilzer filed a bug complaining about that already. I’ll find it.
Comment 9 Darin Adler 2011-06-17 17:26:31 PDT 
It's bug 61572.