Bug 58047 - Web Inspector: remove "enabled" from the setBreakpoint protocol.
Summary: Web Inspector: remove "enabled" from the setBreakpoint protocol.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-07 08:59 PDT by Pavel Feldman
Modified: 2011-06-07 22:05 PDT (History)
11 users (show)

See Also:


Attachments
Patch (29.94 KB, patch)
2011-04-07 10:29 PDT, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-04-07 08:59:15 PDT
There should be no way to add disabled breakpoint. Patch to follow.
Comment 1 Pavel Feldman 2011-04-07 10:29:12 PDT
Created attachment 88658 [details]
Patch
Comment 2 Yury Semikhatsky 2011-04-07 10:41:21 PDT
Comment on attachment 88658 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88658&action=review

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:123
> +                breakpoint.debuggerId = breakpointData.debuggerId;

Extract method.

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:168
> +        if (!sourceFile)

Please remove this, it never happens.

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:274
> +            this._breakpointAdded(breakpoint);

New breakpoint set should be saved.

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:339
> +            this._removeBreakpointFromDebugger(breakpoint);

please pass afterUpdate as a callback to _removeBreakpointFromDebugger

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:395
> +    _breakpointRemoved: function(breakpoint)

Please inline this method.
Comment 3 Pavel Feldman 2011-04-07 11:25:14 PDT
Committed r83190: <http://trac.webkit.org/changeset/83190>