RESOLVED FIXED 58047
Web Inspector: remove "enabled" from the setBreakpoint protocol. 
https://bugs.webkit.org/show_bug.cgi?id=58047
Summary Web Inspector: remove "enabled" from the setBreakpoint protocol.
Pavel Feldman
Reported 2011-04-07 08:59:15 PDT
There should be no way to add disabled breakpoint. Patch to follow.
Attachments
Patch (29.94 KB, patch)
2011-04-07 10:29 PDT, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-04-07 10:29:12 PDT
Created attachment 88658 [details] Patch
Yury Semikhatsky
Comment 2 2011-04-07 10:41:21 PDT
Comment on attachment 88658 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88658&action=review > Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:123 > + breakpoint.debuggerId = breakpointData.debuggerId; Extract method. > Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:168 > + if (!sourceFile) Please remove this, it never happens. > Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:274 > + this._breakpointAdded(breakpoint); New breakpoint set should be saved. > Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:339 > + this._removeBreakpointFromDebugger(breakpoint); please pass afterUpdate as a callback to _removeBreakpointFromDebugger > Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:395 > + _breakpointRemoved: function(breakpoint) Please inline this method.
Pavel Feldman
Comment 3 2011-04-07 11:25:14 PDT
Committed r83190: <http://trac.webkit.org/changeset/83190>
Note You need to log in before you can comment on or make changes to this bug.