Bug 58044 – [Qt][Symbian] Fix Api test failure -- tst_QGraphicsWebView::widgetsRenderingThroughCache

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Yi Shen]

For this test, we should disable the scrollbars on the graphics view since QtWebKit handles scrolling and scrollbar automatically. Will provide a patch.

[Yi Shen]

Created attachment 88638 [details]
first try

[Kenneth Rohde Christiansen]

Comment on attachment 88638 [details]
first try

View in context: https://bugs.webkit.org/attachment.cgi?id=88638&action=review

> Source/WebKit/qt/ChangeLog:5
> +        [Qt][Symbian] Fix Api test failure -- tst_QGraphicsWebView::widgetsRenderingThroughCache

So cache means tiling? If so that is quite confusing.

[Yi Shen]

(In reply to comment #2)
> (From update of attachment 88638 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=88638&action=review
> 
> > Source/WebKit/qt/ChangeLog:5
> > +        [Qt][Symbian] Fix Api test failure -- tst_QGraphicsWebView::widgetsRenderingThroughCache
> 
> So cache means tiling? If so that is quite confusing.

I think so ... see the comments for this test

void tst_QGraphicsWebView::widgetsRenderingThroughCache()
{
    // Widgets should be rendered the same way with and without
    // intermediate cache (tiling for example).
    // See bug https://bugs.webkit.org/show_bug.cgi?id=47767 where
    // widget are rendered as disabled when caching is using.

[Laszlo Gombos]

Comment on attachment 88638 [details]
first try

View in context: https://bugs.webkit.org/attachment.cgi?id=88638&action=review

> Source/WebKit/qt/tests/qgraphicswebview/tst_qgraphicswebview.cpp:-191
> -    viewWithTiling.fill();

Can you explain why is this line removed ?

[Yi Shen]

(In reply to comment #4)
> (From update of attachment 88638 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=88638&action=review
> 
> > Source/WebKit/qt/tests/qgraphicswebview/tst_qgraphicswebview.cpp:-191
> > -    viewWithTiling.fill();
> 
> Can you explain why is this line removed ?

This line is used here to fill the tiling image's background with the white color, which is not necessary in this case since all the tiles should get fully updated and set the background to white automatically.

[Laszlo Gombos]

Comment on attachment 88638 [details]
first try

r=me.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 88638 [details]:

http/tests/xmlhttprequest/basic-auth.html bug 51613 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 88638 [details]
first try

Clearing flags on attachment: 88638

Committed r84332: <http://trac.webkit.org/changeset/84332>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.