Bug 58011 – Web Inspector: [Chromium] Add more tests for detailed heap snapshots UI

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Mikhail Naganov]

Added tests for "Containment" view. Minor refactorings, bugs fixed.

[Mikhail Naganov]

Created attachment 88573 [details]
patch

[Mikhail Naganov]

Created attachment 88579 [details]
reduce test running time (bug 58010)

[Mikhail Naganov]

Created attachment 88596 [details]
split big test into smaller ones

[Mikhail Naganov]

Manually committed http://trac.webkit.org/changeset/83286


2011-04-08  Mikhail Naganov  <[e-mail]>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Add more tests for detailed heap snapshots UI.
        https://bugs.webkit.org/show_bug.cgi?id=58010
        https://bugs.webkit.org/show_bug.cgi?id=58011

        Added tests for "Containment" view. Minor refactorings, bugs fixed.
        Split one large tests into smaller ones to avoid timing out in debug mode.

        Tests: inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting.html
               inspector/profiler/detailed-heapshots-containment-show-all.html
               inspector/profiler/detailed-heapshots-containment-show-next.html
               inspector/profiler/detailed-heapshots-containment-sorting.html
               inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting.html
               inspector/profiler/detailed-heapshots-summary-show-all.html
               inspector/profiler/detailed-heapshots-summary-show-next.html
               inspector/profiler/detailed-heapshots-summary-sorting.html

        * inspector/front-end/DetailedHeapshotGridNodes.js:
        (WebInspector.HeapSnapshotGridNode):
        (WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
        (WebInspector.HeapSnapshotGridNode.prototype.sort.doSort):
        (WebInspector.HeapSnapshotGridNode.prototype.sort):
        (WebInspector.HeapSnapshotGenericObjectNode):
        (WebInspector.HeapSnapshotObjectNode):
        (WebInspector.HeapSnapshotInstanceNode):
        (WebInspector.HeapSnapshotConstructorNode):
        (WebInspector.HeapSnapshotDiffNode):
        (WebInspector.HeapSnapshotDominatorObjectNode):
        * inspector/front-end/DetailedHeapshotView.js:
        (WebInspector.HeapSnapshotContainmentDataGrid):
        (WebInspector.HeapSnapshotDominatorsDataGrid):


2011-04-08  Mikhail Naganov  <[e-mail]>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Add more tests for detailed heap snapshots UI.
        https://bugs.webkit.org/show_bug.cgi?id=58010
        https://bugs.webkit.org/show_bug.cgi?id=58011

        Added tests for "Containment" view. Minor refactorings, bugs fixed.
        Split one large tests into smaller ones to avoid timing out in debug mode.

        * inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting-expected.txt: Added.
        * inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting.html: Added.
        * inspector/profiler/detailed-heapshots-containment-show-all-expected.txt: Added.
        * inspector/profiler/detailed-heapshots-containment-show-all.html: Added.
        * inspector/profiler/detailed-heapshots-containment-show-next-expected.txt: Added.
        * inspector/profiler/detailed-heapshots-containment-show-next.html: Added.
        * inspector/profiler/detailed-heapshots-containment-sorting-expected.txt: Added.
        * inspector/profiler/detailed-heapshots-containment-sorting.html: Added.
        * inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting-expected.txt: Added.
        * inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting.html: Added.
        * inspector/profiler/detailed-heapshots-summary-expected.txt: Removed.
        * inspector/profiler/detailed-heapshots-summary-show-all-expected.txt: Added.
        * inspector/profiler/detailed-heapshots-summary-show-all.html: Added.
        * inspector/profiler/detailed-heapshots-summary-show-next-expected.txt: Added.
        * inspector/profiler/detailed-heapshots-summary-show-next.html: Added.
        * inspector/profiler/detailed-heapshots-summary-sorting-expected.txt: Added.
        * inspector/profiler/detailed-heapshots-summary-sorting.html: Added.
        * inspector/profiler/detailed-heapshots-summary.html: Removed.
        * inspector/profiler/detailed-heapshots-test.js:
        (initialize_DetailedHeapshotTest.InspectorTest.startProfilerTest.detailedHeapProfilesEnabled):
        (initialize_DetailedHeapshotTest.InspectorTest.startProfilerTest):
        (initialize_DetailedHeapshotTest.):
        (initialize_DetailedHeapshotTest):
        * platform/chromium/inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting-expected.txt: Copied from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-summary-expected.txt.
        * platform/chromium/inspector/profiler/detailed-heapshots-containment-show-all-expected.txt: Added.
        * platform/chromium/inspector/profiler/detailed-heapshots-containment-show-next-expected.txt: Added.
        * platform/chromium/inspector/profiler/detailed-heapshots-containment-sorting-expected.txt: Added.
        * platform/chromium/inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-summary-expected.txt.
        * platform/chromium/inspector/profiler/detailed-heapshots-summary-show-all-expected.txt: Added.
        * platform/chromium/inspector/profiler/detailed-heapshots-summary-show-next-expected.txt: Added.
        * platform/chromium/inspector/profiler/detailed-heapshots-summary-sorting-expected.txt: Added.
        * platform/chromium/test_expectations.txt: