Bug 58002 - REGRESSION (r73993): Default Arabic line spacing has gotten very loose when the specified font is not Arabic
Summary: REGRESSION (r73993): Default Arabic line spacing has gotten very loose when t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh OS X 10.6
: P1 Normal
Assignee: Nobody
URL:
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2011-04-06 17:52 PDT by mitz
Modified: 2011-04-06 20:07 PDT (History)
3 users (show)

See Also:


Attachments
Do not apply vertical metrics tweaks to Geeza Pro except in Leopard (388.55 KB, patch)
2011-04-06 17:57 PDT, mitz
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2011-04-06 17:52:28 PDT
<rdar://problem/9084761>
Comment 1 mitz 2011-04-06 17:57:46 PDT
Created attachment 88550 [details]
Do not apply vertical metrics tweaks to Geeza Pro except in Leopard
Comment 2 mitz 2011-04-06 18:03:24 PDT
Committed r83126. <http://trac.webkit.org/changeset/83126>
Comment 3 WebKit Review Bot 2011-04-06 19:04:09 PDT
http://trac.webkit.org/changeset/83126 might have broken SnowLeopard Intel Release (Tests)
The following tests are not passing:
fast/dom/52776.html
fast/text/complex-text-opacity.html
fast/text/international/bidi-AN-after-L.html
fast/text/international/bidi-AN-after-empty-run.html
fast/text/international/bidi-CS-after-AN.html
fast/text/international/bidi-mirror-he-ar.html
fast/text/international/bidi-neutral-run.html
platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html
Comment 4 mitz 2011-04-06 19:38:46 PDT
(In reply to comment #3)
> http://trac.webkit.org/changeset/83126 might have broken SnowLeopard Intel Release (Tests)
> The following tests are not passing:
> fast/dom/52776.html
> fast/text/complex-text-opacity.html
> fast/text/international/bidi-AN-after-L.html
> fast/text/international/bidi-AN-after-empty-run.html
> fast/text/international/bidi-CS-after-AN.html
> fast/text/international/bidi-mirror-he-ar.html
> fast/text/international/bidi-neutral-run.html
> platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html

I am going to double check the results I have generated.
Comment 5 mitz 2011-04-06 20:07:05 PDT
Tried to land the correct expected results in r83132