Bug 57999 - clearIfComposited call is really slow
Summary: clearIfComposited call is really slow
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: John Bauman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-06 16:58 PDT by John Bauman
Modified: 2011-04-07 20:09 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.68 KB, patch)
2011-04-06 17:04 PDT, John Bauman 		no flags Details | Formatted Diff | Diff
Fix patch (1.67 KB, patch)
2011-04-07 13:35 PDT, John Bauman 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Bauman 2011-04-06 16:58:55 PDT 
clearIfComposited call is really slow
Comment 1 John Bauman 2011-04-06 17:04:03 PDT 
Created attachment 88544 [details]
Patch
Comment 2 Kenneth Russell 2011-04-06 19:02:13 PDT 
Comment on attachment 88544 [details]
Patch

Looks good.
Comment 3 WebKit Commit Bot 2011-04-06 20:57:32 PDT 
Comment on attachment 88544 [details]
Patch

Rejecting attachment 88544 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'land-a..." exit_code: 2

Last 500 characters of output:
LayoutTestControllerQt.cpp
	M	Tools/DumpRenderTree/qt/DumpRenderTreeQt.cpp
	M	Tools/ChangeLog
r83137 = 7f2c250c078454d645915dace97b96aef2626877 (refs/remotes/trunk)
	M	Tools/DumpRenderTree/mac/DumpRenderTree.mm
	M	Tools/DumpRenderTree/LayoutTestController.cpp
	M	Tools/DumpRenderTree/LayoutTestController.h
	M	Tools/ChangeLog
r83138 = 8fef0c2b86f5af6c92684d29e9b2e11bf6f5822f (refs/remotes/trunk)
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/trunk.

Full output: http://queues.webkit.org/results/8348429
Comment 4 Kenneth Russell 2011-04-07 13:18:13 PDT 
You need to take out the "No new tests. OOPS!" line from your ChangeLog. Could you upload a new patch?
Comment 5 John Bauman 2011-04-07 13:35:28 PDT 
Created attachment 88684 [details]
Fix patch
Comment 6 Kenneth Russell 2011-04-07 13:42:43 PDT 
Comment on attachment 88684 [details]
Fix patch

Looks good.
Comment 7 WebKit Commit Bot 2011-04-07 20:09:35 PDT 
Comment on attachment 88684 [details]
Fix patch

Clearing flags on attachment: 88684

Committed r83242: <http://trac.webkit.org/changeset/83242>
Comment 8 WebKit Commit Bot 2011-04-07 20:09:40 PDT 
All reviewed patches have been landed.  Closing bug.