Bug 57984 - WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels
Summary: WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Chang Shu
Depends on:
Reported: 2011-04-06 14:31 PDT by Chang Shu
Modified: 2011-04-06 21:00 PDT (History)
2 users (show)

See Also:

fix patch (9.10 KB, patch)
2011-04-06 14:35 PDT, Chang Shu
darin: review+
Details | Formatted Diff | Diff
r+ed patch with minor changes based on review (9.09 KB, patch)
2011-04-06 18:00 PDT, Chang Shu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chang Shu 2011-04-06 14:31:47 PDT
failing printing/page-format-data-display-none.html
Comment 1 Chang Shu 2011-04-06 14:35:07 PDT
Created attachment 88514 [details]
fix patch
Comment 2 Darin Adler 2011-04-06 17:16:53 PDT
Comment on attachment 88514 [details]
fix patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88514&action=review

> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:183
> +        return "";

I suggest String() instead of "".

> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:186
> +    return PrintContext::pageSizeAndMarginsInPixels(coreFrame, pageIndex, width, height,
> +                                                    marginTop, marginRight, marginBottom, marginLeft);

We don’t line up lines like this in WebKit. I suggest either doing a 4 pixel indent rather than lining things up or just putting all the arguments into one line.
Comment 3 Chang Shu 2011-04-06 18:00:34 PDT
Created attachment 88551 [details]
r+ed patch with minor changes based on review
Comment 4 WebKit Commit Bot 2011-04-06 21:00:23 PDT
Comment on attachment 88551 [details]
r+ed patch with minor changes based on review

Clearing flags on attachment: 88551

Committed r83139: <http://trac.webkit.org/changeset/83139>
Comment 5 WebKit Commit Bot 2011-04-06 21:00:27 PDT
All reviewed patches have been landed.  Closing bug.