-[AVPlayerItem isPlaybackBufferEmpty] often returns incorrect results. Instead, call -[AVPlayerItem loadedTimeRanges] and determine if the current time resides within those ranges.
<rdar://problem/9245087>
This might result in the platformBufferedTimeRanges() being called more often. The tradeoff here is performance vs. correctness. As it stands, the current implementation, due to bugs in AVFoundation, is incorrect.
Created attachment 88512 [details] Patch
Comment on attachment 88512 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88512&action=review r!=me > Source/WebCore/ChangeLog:8 > + Query our cached loaded time array instead of asking AVPlayerItem if it's buffer is empty. it's -> its
Created attachment 88519 [details] Patch Fixed some inverted conditionals and extraneous apostrophes.
Comment on attachment 88519 [details] Patch That function name, contain, is really strange. It’s a verb.
(In reply to comment #6) > (From update of attachment 88519 [details]) > That function name, contain, is really strange. It’s a verb. I know, I intensely dislike it. Thanks for the review!
Comment on attachment 88519 [details] Patch Clearing flags on attachment: 88519 Committed r83135: <http://trac.webkit.org/changeset/83135>
All reviewed patches have been landed. Closing bug.