WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
57981
Update the CSS3 column width and count algorithm to match the spec.
https://bugs.webkit.org/show_bug.cgi?id=57981
Summary
Update the CSS3 column width and count algorithm to match the spec.
Dave Hyatt
Reported
2011-04-06 14:07:44 PDT
Update the CSS3 column width and count algorithm to match the spec. I honestly have no idea what the differences are. None of our tests change results. I just want the code to match the pseudo-algorithm in the latest draft.
Attachments
Patch
(3.28 KB, patch)
2011-04-06 14:09 PDT
,
Dave Hyatt
simon.fraser
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dave Hyatt
Comment 1
2011-04-06 14:09:15 PDT
Created
attachment 88508
[details]
Patch
Simon Fraser (smfr)
Comment 2
2011-04-06 14:13:20 PDT
Comment on
attachment 88508
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=88508&action=review
> Source/WebCore/rendering/RenderBlock.cpp:4215 > + desiredColumnCount = max(1, (int)((float)(availWidth + colGap) / (colWidth + colGap)));
To avoid the (int) cast you could use max<int>().
> Source/WebCore/rendering/RenderBlock.cpp:4218 > + desiredColumnCount = min(colCount, (int)((float)(availWidth + colGap) / (colWidth + colGap)));
Ditto
Dave Hyatt
Comment 3
2011-04-06 14:23:06 PDT
Fixed in
r83099
.
WebKit Review Bot
Comment 4
2011-04-06 14:26:08 PDT
Attachment 88508
[details]
did not build on chromium: Build output:
http://queues.webkit.org/results/8348315
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug