Bug 57974 - [Qt] We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
Summary: [Qt] We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P4 Minor
Assignee: Alexis Menard (darktears)
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-04-06 13:01 PDT by Alexis Menard (darktears)
Modified: 2011-04-06 15:17 PDT (History)
4 users (show)

See Also:


Attachments
Proposed patch. (15.94 KB, patch)
2011-04-06 13:03 PDT, Alexis Menard (darktears)
no flags Details | Formatted Diff | Diff
V2 with changelog's typo fixed. (15.94 KB, patch)
2011-04-06 13:07 PDT, Alexis Menard (darktears)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexis Menard (darktears) 2011-04-06 13:01:18 PDT
We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA), it sounds better and is aligned with what the others do.
Comment 1 Alexis Menard (darktears) 2011-04-06 13:03:32 PDT
Created attachment 88495 [details]
Proposed patch.
Comment 2 Alexis Menard (darktears) 2011-04-06 13:07:11 PDT
Created attachment 88496 [details]
V2 with changelog's typo fixed.
Comment 3 Andreas Kling 2011-04-06 13:09:02 PDT
Comment on attachment 88496 [details]
V2 with changelog's typo fixed.

Good idea.
Comment 4 WebKit Commit Bot 2011-04-06 15:17:31 PDT
Comment on attachment 88496 [details]
V2 with changelog's typo fixed.

Clearing flags on attachment: 88496

Committed r83108: <http://trac.webkit.org/changeset/83108>
Comment 5 WebKit Commit Bot 2011-04-06 15:17:38 PDT
All reviewed patches have been landed.  Closing bug.