Bug 57962 - AVF: MediaPlayerPrivateAVFoundation never reaches playable state.
Summary: AVF: MediaPlayerPrivateAVFoundation never reaches playable state.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-04-06 10:51 PDT by Jer Noble
Modified: 2011-04-07 12:31 PDT (History)
0 users

See Also:


Attachments
Patch (8.53 KB, patch)
2011-04-06 14:39 PDT, Jer Noble
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2011-04-06 10:51:30 PDT
Because it compares two float times in seekToTime() which are slightly different but resolve to the same CMTime, no timeChanged event is ever fired.
Comment 1 Jer Noble 2011-04-06 10:55:22 PDT
<rdar://problem/9243510>
Comment 2 Jer Noble 2011-04-06 14:39:37 PDT
Created attachment 88516 [details]
Patch
Comment 3 Maciej Stachowiak 2011-04-06 23:45:27 PDT
Comment on attachment 88516 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88516&action=review

r=me

> Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:-634
> -    LOG(Media, "MediaPlayerPrivateAVFoundation::scheduleMainThreadNotification(%p) - notification %d", this, static_cast<int>(type));

Why remove this log call? Looks like it got copied to the new overload only, which seems a bit odd.
Comment 4 Jer Noble 2011-04-07 07:50:45 PDT
(In reply to comment #3)
> (From update of attachment 88516 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=88516&action=review
> 
> r=me
> 
> > Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:-634
> > -    LOG(Media, "MediaPlayerPrivateAVFoundation::scheduleMainThreadNotification(%p) - notification %d", this, static_cast<int>(type));
> 
> Why remove this log call? Looks like it got copied to the new overload only, which seems a bit odd.

The two other scheduleMainThreadNotification() functions (the one taking a float, and the one taking a bool) funnel into this one (which takes a full blown Notification), so the LOG message is effectively called from each.

Thanks!
Comment 5 Jer Noble 2011-04-07 12:31:13 PDT
Committed r83196: <http://trac.webkit.org/changeset/83196>