Bug 57962 – AVF: MediaPlayerPrivateAVFoundation never reaches playable state.

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Jer Noble]

Because it compares two float times in seekToTime() which are slightly different but resolve to the same CMTime, no timeChanged event is ever fired.

[Jer Noble]

<rdar://problem/9243510>

[Jer Noble]

Created attachment 88516 [details]
Patch

[Maciej Stachowiak]

Comment on attachment 88516 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88516&action=review

r=me

> Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:-634
> -    LOG(Media, "MediaPlayerPrivateAVFoundation::scheduleMainThreadNotification(%p) - notification %d", this, static_cast<int>(type));

Why remove this log call? Looks like it got copied to the new overload only, which seems a bit odd.

[Jer Noble]

(In reply to comment #3)
> (From update of attachment 88516 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=88516&action=review
> 
> r=me
> 
> > Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:-634
> > -    LOG(Media, "MediaPlayerPrivateAVFoundation::scheduleMainThreadNotification(%p) - notification %d", this, static_cast<int>(type));
> 
> Why remove this log call? Looks like it got copied to the new overload only, which seems a bit odd.

The two other scheduleMainThreadNotification() functions (the one taking a float, and the one taking a bool) funnel into this one (which takes a full blown Notification), so the LOG message is effectively called from each.

Thanks!

[Jer Noble]

Committed r83196: <http://trac.webkit.org/changeset/83196>