Bug 57958 – Context menu does not show in PDF views if there is no UI delegate

• Status: RESOLVED
• Resolution: FIXED
• Component: PDF

[Timothy Hatcher]

A WebView with no UI delegate does not show a context menu in PDF view.

[Timothy Hatcher]

Created attachment 88464 [details]
Proposed Change

This bug is blocking me from testing an upcoming context menu change.

[WebKit Review Bot]

Attachment 88464 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style']" exit_code: 1

Source/WebKit/mac/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Adler]

Comment on attachment 88464 [details]
Proposed Change

View in context: https://bugs.webkit.org/attachment.cgi?id=88464&action=review

> Source/WebKit/mac/WebView/WebView.mm:1277
> +    // CallUIDelegate returns nil if UIDelegate is nil or dosen't respond to the selector. So we need to check that here

Typo: dosen't

> Source/WebKit/mac/WebView/WebView.mm:1281
> +        menuItems = CallUIDelegate(self, selector, element, defaultMenuItems);

Annoying to be doing respondsToSelector twice here.

[Timothy Hatcher]

(In reply to comment #3)
> (From update of attachment 88464 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=88464&action=review
> 
> > Source/WebKit/mac/WebView/WebView.mm:1281
> > +        menuItems = CallUIDelegate(self, selector, element, defaultMenuItems);
> 
> Annoying to be doing respondsToSelector twice here.

We could have an out parameter to know if the delegate responds. But that would be a larger change, and WebKit1 is the past!

[Timothy Hatcher]

Landed in r83464.