RESOLVED FIXED 57949
Web Inspector: get rid of Breakpoint.js. 
https://bugs.webkit.org/show_bug.cgi?id=57949
Summary Web Inspector: get rid of Breakpoint.js.
Pavel Feldman
Reported 2011-04-06 08:00:40 PDT
Patch to follow.
Attachments
[PATCH] Work in progress. (33.16 KB, patch)
2011-04-06 08:02 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Patch (30.36 KB, patch)
2011-04-07 05:40 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Patch (30.64 KB, patch)
2011-04-07 07:40 PDT, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-04-06 08:02:27 PDT
Created attachment 88418 [details] [PATCH] Work in progress.
Pavel Feldman
Comment 2 2011-04-07 05:40:51 PDT
Created attachment 88611 [details] Patch
Pavel Podivilov
Comment 3 2011-04-07 06:09:26 PDT
Comment on attachment 88611 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88611&action=review > Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:323 > + var scriptLocation = breakpoint.location ? breakpoint.location : {lineNumber:breakpoint.lineNumber, columnNumber:0}; Here breakpoint.lineNumber may denote location in formatter script. We should not map it in that case. > Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:371 > + var pendingBreakpoints = this._breakpointsWithoutSourceFile[sourceFileId]; Please mind that sourceFileId would be undefined for all breakpoints created with the old version. When such breakpoints would be purged? Probably it's better to ignore them here?
Pavel Feldman
Comment 4 2011-04-07 07:40:51 PDT
Created attachment 88634 [details] Patch
Pavel Podivilov
Comment 5 2011-04-07 08:01:38 PDT
(In reply to comment #4) > Created an attachment (id=88634) [details] > Patch Looks good.
Pavel Feldman
Comment 6 2011-04-07 08:47:49 PDT
Committed r83176: <http://trac.webkit.org/changeset/83176>
Note You need to log in before you can comment on or make changes to this bug.