Bug 57945 - [Qt][WK2] Make sure qwkhistory.h is copied into includes/WebKit2
Summary: [Qt][WK2] Make sure qwkhistory.h is copied into includes/WebKit2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-04-06 06:44 PDT by Jamie Cooley
Modified: 2011-04-08 08:38 PDT (History)
4 users (show)

See Also:

Attachments
proposed patch to copy qwkhistory.h into includes/WebKit2 (992 bytes, patch)
2011-04-06 06:57 PDT, Jamie Cooley 		benjamin: review-
Details | Formatted Diff | Diff
proposed patch to copy qwkhistory.h into includes/WebKit2 (1.47 KB, text/plain)
2011-04-07 07:48 PDT, Jamie Cooley 		no flags Details
proposed patch to copy qwkhistory.h into includes/WebKit2 (1.74 KB, patch)
2011-04-07 08:16 PDT, Jamie Cooley 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jamie Cooley 2011-04-06 06:44:41 PDT 
qwkpage, qwkpreferences were copied as of r72039; qwkhistory is not.
Comment 1 Jamie Cooley 2011-04-06 06:57:23 PDT 
Created attachment 88411 [details]
proposed patch to copy qwkhistory.h into includes/WebKit2
Comment 2 Early Warning System Bot 2011-04-06 07:08:41 PDT 
Attachment 88411 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8343182
Comment 3 Jamie Cooley 2011-04-06 07:17:07 PDT 
(In reply to comment #2)
> Attachment 88411 [details] did not build on qt:
> Build output: http://queues.webkit.org/results/8343182

OK, I will take a look at this.
Comment 4 Benjamin Poulain 2011-04-06 08:57:54 PDT 
Comment on attachment 88411 [details]
proposed patch to copy qwkhistory.h into includes/WebKit2

R-, does not build :)

Make sure you check the checkbox "patch" when uploading a patch...
Comment 5 Jamie Cooley 2011-04-07 07:48:27 PDT 
Created attachment 88636 [details]
proposed patch to copy qwkhistory.h into includes/WebKit2

And this one builds! ;)
Comment 6 WebKit Review Bot 2011-04-07 07:49:43 PDT 
Attachment 88636 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/UIProcess/API/qt/qwkhistory.h:31:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Jamie Cooley 2011-04-07 08:16:58 PDT 
Created attachment 88641 [details]
proposed patch to copy qwkhistory.h into includes/WebKit2
Comment 8 Benjamin Poulain 2011-04-08 07:03:00 PDT 
Comment on attachment 88641 [details]
proposed patch to copy qwkhistory.h into includes/WebKit2

Looks ok. I would have liked a comment in the Changelog about the change of qwkhistory.h but that is not important.
Comment 9 WebKit Commit Bot 2011-04-08 08:38:21 PDT 
Comment on attachment 88641 [details]
proposed patch to copy qwkhistory.h into includes/WebKit2

Clearing flags on attachment: 88641

Committed r83297: <http://trac.webkit.org/changeset/83297>
Comment 10 WebKit Commit Bot 2011-04-08 08:38:28 PDT 
All reviewed patches have been landed.  Closing bug.