Bug 57943 - Move RenderBlock::positionNewFloatOnLine to RenderBlockLineLayout.cpp
Summary: Move RenderBlock::positionNewFloatOnLine to RenderBlockLineLayout.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 57851
  Show dependency treegraph
 
Reported: 2011-04-06 05:58 PDT by Ryosuke Niwa
Modified: 2011-04-06 08:20 PDT (History)
4 users (show)

See Also:


Attachments
cleanup (5.61 KB, patch)
2011-04-06 06:07 PDT, Ryosuke Niwa
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-04-06 05:58:04 PDT
positionNewFloatOnLine is only used in RenderBlockLineLayout.cpp.  We should move this function to RenderBlockLineLayout.cpp.
Comment 1 Ryosuke Niwa 2011-04-06 06:07:45 PDT
Created attachment 88404 [details]
cleanup
Comment 2 Eric Seidel (no email) 2011-04-06 06:08:56 PDT
Comment on attachment 88404 [details]
cleanup

Yay simple patches!
Comment 3 Ryosuke Niwa 2011-04-06 07:10:16 PDT
Committed r83042: <http://trac.webkit.org/changeset/83042>
Comment 4 WebKit Review Bot 2011-04-06 07:34:03 PDT
http://trac.webkit.org/changeset/83042 might have broken GTK Linux 64-bit Debug
Comment 5 mitz 2011-04-06 08:13:38 PDT
RenderBlock.h used to list functions implemented in RenderBlockLineLayout.cpp in a separate section. Perhaps this is no longer the case.
Comment 6 Ryosuke Niwa 2011-04-06 08:17:19 PDT
(In reply to comment #5)
> RenderBlock.h used to list functions implemented in RenderBlockLineLayout.cpp in a separate section. Perhaps this is no longer the case.

Oops, I missed that.  Fixing it now.
Comment 7 Ryosuke Niwa 2011-04-06 08:20:21 PDT
Fixed RenderBlock.h in http://trac.webkit.org/changeset/83052.