WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
57943
Move RenderBlock::positionNewFloatOnLine to RenderBlockLineLayout.cpp
https://bugs.webkit.org/show_bug.cgi?id=57943
Summary
Move RenderBlock::positionNewFloatOnLine to RenderBlockLineLayout.cpp
Ryosuke Niwa
Reported
2011-04-06 05:58:04 PDT
positionNewFloatOnLine is only used in RenderBlockLineLayout.cpp. We should move this function to RenderBlockLineLayout.cpp.
Attachments
cleanup
(5.61 KB, patch)
2011-04-06 06:07 PDT
,
Ryosuke Niwa
eric
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2011-04-06 06:07:45 PDT
Created
attachment 88404
[details]
cleanup
Eric Seidel (no email)
Comment 2
2011-04-06 06:08:56 PDT
Comment on
attachment 88404
[details]
cleanup Yay simple patches!
Ryosuke Niwa
Comment 3
2011-04-06 07:10:16 PDT
Committed
r83042
: <
http://trac.webkit.org/changeset/83042
>
WebKit Review Bot
Comment 4
2011-04-06 07:34:03 PDT
http://trac.webkit.org/changeset/83042
might have broken GTK Linux 64-bit Debug
mitz
Comment 5
2011-04-06 08:13:38 PDT
RenderBlock.h used to list functions implemented in RenderBlockLineLayout.cpp in a separate section. Perhaps this is no longer the case.
Ryosuke Niwa
Comment 6
2011-04-06 08:17:19 PDT
(In reply to
comment #5
)
> RenderBlock.h used to list functions implemented in RenderBlockLineLayout.cpp in a separate section. Perhaps this is no longer the case.
Oops, I missed that. Fixing it now.
Ryosuke Niwa
Comment 7
2011-04-06 08:20:21 PDT
Fixed RenderBlock.h in
http://trac.webkit.org/changeset/83052
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug