RESOLVED FIXED 57938
Add member functions for determining line/paragraph separation to InlineIterator 
https://bugs.webkit.org/show_bug.cgi?id=57938
Summary Add member functions for determining line/paragraph separation to InlineIterator
Levi Weintraub
Reported 2011-04-06 03:23:19 PDT
These checks are currently done by calling into public member variables of InlineIterator, and should be cleaned up. Also adding "preservesNewline" to RenderObject.
Attachments
Patch (5.79 KB, patch)
2011-04-06 04:16 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Patch (5.82 KB, patch)
2011-04-06 04:56 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Levi Weintraub
Comment 1 2011-04-06 04:16:37 PDT
Created attachment 88392 [details] Patch
Ryosuke Niwa
Comment 2 2011-04-06 04:39:12 PDT
Comment on attachment 88392 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88392&action=review > Source/WebCore/rendering/InlineIterator.h:71 > + inline bool isHardTextLinebreak() Since this is a member function of an iterator, would atHardTextLinebreak makes more sense? But what does hard text line break really mean? Is this terminology used elsewhere? Maybe atPreservedLineBreak makes more sense? > Source/WebCore/rendering/InlineIterator.h:77 > + inline bool isParagraphSeparator() Ditto: s/is/at/
Levi Weintraub
Comment 3 2011-04-06 04:46:39 PDT
Comment on attachment 88392 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88392&action=review >> Source/WebCore/rendering/InlineIterator.h:71 >> + inline bool isHardTextLinebreak() > > Since this is a member function of an iterator, would atHardTextLinebreak makes more sense? But what does hard text line break really mean? Is this terminology used elsewhere? Maybe atPreservedLineBreak makes more sense? At sounds fine. HardLineBreak is the terminology used in BidiResolver (see: createBidiRunsForLine). Though we don't yet support it, when we add support for Unicode Paragraph Separators (https://bugs.webkit.org/show_bug.cgi?id=53203), this won't just be applicable to preserved newline characters. How about atTextParagraphSeparator, as this is how it will be treated when running Unicode BiDi algorithm?
Levi Weintraub
Comment 4 2011-04-06 04:56:36 PDT
Created attachment 88396 [details] Patch
Levi Weintraub
Comment 5 2011-04-06 05:13:05 PDT
Comment on attachment 88396 [details] Patch Clearing flags on attachment: 88396 Committed r83038: <http://trac.webkit.org/changeset/83038>
Levi Weintraub
Comment 6 2011-04-06 05:13:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.