Bug 57932 - [GTK] DumpRenderTree: do not try to free NULL SoupURIs
Summary: [GTK] DumpRenderTree: do not try to free NULL SoupURIs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-06 02:27 PDT by Sergio Villar Senin
Modified: 2011-04-06 10:32 PDT (History)
0 users

See Also:


Attachments
Patch (1.88 KB, patch)
2011-04-06 02:31 PDT, Sergio Villar Senin
mrobinson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2011-04-06 02:27:28 PDT
[GTK] DumpRenderTree: do not try to free NULL SoupURIs
Comment 1 Sergio Villar Senin 2011-04-06 02:31:11 PDT
Created attachment 88386 [details]
Patch
Comment 2 Philippe Normand 2011-04-06 04:58:13 PDT
Comment on attachment 88386 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88386&action=review

Thanks for fixing this :)

> Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:1057
> +    if (uri && SOUP_URI_VALID_FOR_HTTP(uri) && g_strcmp0(uri->host, "127.0.0.1")

SOUP_URI_VALID_FOR_HTTP() already checks the uri, so no need for that extra check I think.
Comment 3 Martin Robinson 2011-04-06 06:53:09 PDT
Comment on attachment 88386 [details]
Patch

Nice fix. If Philippe is correct, please remove the first check.
Comment 4 Sergio Villar Senin 2011-04-06 10:32:49 PDT
Committed r83068: <http://trac.webkit.org/changeset/83068>