Bug 57928 - Web Inspector: migrate debugger domain to the unified breakpoint location notion.
Summary: Web Inspector: migrate debugger domain to the unified breakpoint location not...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-06 01:37 PDT by Pavel Feldman
Modified: 2011-04-07 05:50 PDT (History)
10 users (show)

See Also:


Attachments
Patch (15.84 KB, patch)
2011-04-06 01:46 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff
Patch (15.85 KB, patch)
2011-04-07 05:43 PDT, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-04-06 01:37:58 PDT
Simple refactoring, patch to follow.
Comment 1 Pavel Feldman 2011-04-06 01:46:17 PDT
Created attachment 88383 [details]
Patch
Comment 2 Yury Semikhatsky 2011-04-07 05:36:28 PDT
Comment on attachment 88383 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88383&action=review

> Source/WebCore/inspector/InspectorDebuggerAgent.cpp:190
> +    if (location)

Should be if (*location), r- for this.
Comment 3 Pavel Feldman 2011-04-07 05:43:01 PDT
Created attachment 88612 [details]
Patch
Comment 4 Pavel Feldman 2011-04-07 05:50:29 PDT
Committed r83164: <http://trac.webkit.org/changeset/83164>