Bug 57926 – [chromium] Failing GPU video tests

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[James Kozianski]

media/video-display-toggle.html
media/video-no-audio.html
media/video-volume-slider.html

are all failing on the canary bots. History:

1. r82969 caused many test failures
2. 83002 changed many of those test failures into rebaselines
3. 83017, 83019 and 83025 were the patches for those rebaselines

After this, the above tests are still failing in webkit_gpu_tests.

I'm going to update update test_expectations.txt, could you please decide whether a rebaseline is appropriate?

[James Kozianski]

Committed r83027: <http://trac.webkit.org/changeset/83027>

[James Kozianski]

Accidentally closed.

[WebKit Review Bot]

http://trac.webkit.org/changeset/83027 might have broken GTK Linux 32-bit Debug

[Andrew Scherkus]

adding vrk to review any rebaselines as needed

[Victoria Kirst]

Created attachment 89515 [details]
Patch

[Victoria Kirst]

Seems like a rebaseline makes sense!

And actually, the rebaseline script failed for me when I initially tried to run it, so I also included my slight modifications to the script to include the correct directories. Added dpranke to review.

[James Robinson]

Comment on attachment 89515 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89515&action=review

> Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:79
> -    'chromium-gpu-mac-leopard': 'Webkit_Mac10_5_-_GPU',
> +    'chromium-gpu-mac-snowleopard': 'Webkit_Mac10_6_-_GPU',
>      'chromium-gpu-win-xp': 'Webkit_Win_-_GPU',
> +    'chromium-gpu-win-win7': 'Webkit_Win7_-_GPU',
>      'chromium-gpu-linux': 'Webkit_Linux_-_GPU',
> +    'chromium-gpu-linux-x86_64': 'Webkit_Linux_64_-_GPU',

Did you mean to change this?

[James Robinson]

Ah, ok - Dirk should check the script changes.  If they are correct feel free to flip c-q.

[Dirk Pranke]

Comment on attachment 89515 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=89515&action=review

>> Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:79
>> +    'chromium-gpu-linux-x86_64': 'Webkit_Linux_64_-_GPU',
> 
> Did you mean to change this?

All three lines look fine to me. I had just added the -x86_64 line to the non-gpu config, so it makes sense that they added the gpu version as well.

[James Robinson]

Comment on attachment 89515 [details]
Patch

Clearing flags on attachment: 89515

Committed r83824: <http://trac.webkit.org/changeset/83824>

[James Robinson]

All reviewed patches have been landed.  Closing bug.