Bug 57920 - REGRESSION(r83007): Broke WebFrameTest.FrameForEnteredContext on Chromium-win and Chromium-mac (Requested by tkent on #webkit).
Summary: REGRESSION(r83007): Broke WebFrameTest.FrameForEnteredContext on Chromium-win...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: WebKit Review Bot
URL:
Keywords:
Depends on:
Blocks: 57516
  Show dependency tree / graph
 
Reported: 2011-04-05 22:54 PDT by WebKit Review Bot
Modified: 2011-04-07 16:29 PDT (History)
4 users (show)

See Also:

Attachments
ROLLOUT of r83007 (8.66 KB, patch)
2011-04-05 22:54 PDT, WebKit Review Bot 		no flags Details | Formatted Diff | Diff
Patch (8.67 KB, patch)
2011-04-07 16:18 PDT, Aaron Boodman 		levin: review-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2011-04-05 22:54:19 PDT 
http://trac.webkit.org/changeset/83007 broke the build:
Broke WebFrameTest.FrameForEnteredContext on Chromium-win and Chromium-mac (Requested by tkent on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2011-04-05 22:54:42 PDT 
Created attachment 88368 [details]
ROLLOUT of r83007

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID --ignore-builders

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 WebKit Commit Bot 2011-04-05 23:01:18 PDT 
Comment on attachment 88368 [details]
ROLLOUT of r83007

Clearing flags on attachment: 88368

Committed r83021: <http://trac.webkit.org/changeset/83021>
Comment 3 WebKit Commit Bot 2011-04-05 23:01:24 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 WebKit Review Bot 2011-04-06 01:52:38 PDT 
http://trac.webkit.org/changeset/83021 might have broken GTK Linux 32-bit Debug
Comment 5 Aaron Boodman 2011-04-07 16:18:39 PDT 
Created attachment 88724 [details]
Patch

There needs to be an active locker to use v8.
Comment 6 David Levin 2011-04-07 16:25:18 PDT 
Comment on attachment 88724 [details]
Patch

Consider a new bug.
Comment 7 Aaron Boodman 2011-04-07 16:29:54 PDT 
Sorry, I at first thought this bug was autogenerated for me to use when fixing the regression.

I will create a new one.