Bug 57918 – Add QUOTA build flag for unified quota API

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Kinuko Yasuda]

Per public discussion on public-webapps, we need unified quota API that allows webapps to request/query the current storage usage and quota.  The spec is not fully specified yet and is subject to change, and the feature should be guarded by a new compile time flag.

http://lists.w3.org/Archives/Public/public-webapps/2011JanMar/0346.html

[Dai Mikurube]

Created attachment 88369 [details]
The first patch to add QUOTA flag

[Kinuko Yasuda]

Comment on attachment 88369 [details]
The first patch to add QUOTA flag

Thanks for working on this!

View in context: https://bugs.webkit.org/attachment.cgi?id=88369&action=review

Have you forgotten to add the similar change in configure.ac (and top level ChangeLog)?

> Source/WebCore/ChangeLog:1
> [phone]  Dai Mikurube  <[e-mail]>

Different address from the one in others (chromium.org vs google.com).

> Source/WebCore/WebCore.pri:169
> +!contains(DEFINES, ENABLE_QUOTA=.): DEFINES += ENABLE_QUOTA=0 

Seems like we should put this in Source/WebCore/features.pri instead?

> Source/WebKit/chromium/ChangeLog:1
> [phone]  Dai Mikurube  <[e-mail]>

ditto.

> Source/WebKit/chromium/features.gypi:78
> +        'ENABLE_QUOTA=1',

Please do not enable this yet.  (You can just remove this line for now)

> Source/WebKit/mac/ChangeLog:1
> [phone]  Dai Mikurube  <[e-mail]>

ditto.

> WebKitLibraries/ChangeLog:1
> [phone]  Dai Mikurube  <[e-mail]>

ditto.

[Dai Mikurube]

Created attachment 88379 [details]
Patch

[Dai Mikurube]

Thank you for your comments. Modified the patch.

[Kinuko Yasuda]

Comment on attachment 88379 [details]
Patch

Thanks, looks good to me.

[Kinuko Yasuda]

Committed r83133: <http://trac.webkit.org/changeset/83133>