Bug 57893 - [Mac] WebKit2: Escape key does not stop page loads when focus is on the web page
Summary: [Mac] WebKit2: Escape key does not stop page loads when focus is on the web page
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-04-05 15:27 PDT by Darin Adler
Modified: 2011-04-05 17:55 PDT (History)
1 user (show)

See Also:


Attachments
Patch (17.48 KB, patch)
2011-04-05 17:07 PDT, Darin Adler
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2011-04-05 15:27:27 PDT
[MAC] WebKit2: Escape key does not stop page loads when focus is on the web page
Comment 1 Darin Adler 2011-04-05 15:28:08 PDT
<rdar://problem/9130486>
Comment 2 Darin Adler 2011-04-05 17:07:20 PDT
Created attachment 88337 [details]
Patch
Comment 3 Darin Adler 2011-04-05 17:07:59 PDT
Alexey, this is the bug you asked me to fix.
Comment 4 Alexey Proskuryakov 2011-04-05 17:30:59 PDT
Comment on attachment 88337 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88337&action=review

> Source/WebKit2/UIProcess/PageClient.h:104
> +    virtual bool executeKeypressCommand(const String& selector) = 0;

Keypress may confuse someone into thinking that the command is executed when keypress is dispatched. But it's for keydown, as far as I can tell.
Comment 5 Darin Adler 2011-04-05 17:55:40 PDT
Committed r83004: <http://trac.webkit.org/changeset/83004>