WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
57890
Hierarchy of renderers for elements with a document needs to be unified
https://bugs.webkit.org/show_bug.cgi?id=57890
Summary
Hierarchy of renderers for elements with a document needs to be unified
Chris Marrin
Reported
2011-04-05 15:11:55 PDT
Today, we have 3 elements which can contain an HTML document: HTMLIFrameElement, HTMLFrameElement and HTMLObjectElement. Their renderers are: RenderIFrame, RenderFrame and RenderEmbeddedObject, respectively. Their hierarchy is: ... RenderPart RenderEmbeddedObject RenderFrameBase RenderIFrame RenderFrame So common functionality has to go into RenderPart, which is really too broad. It would be better with an added class: ... RenderPart RenderFrameOwner RenderEmbeddedObject RenderFrameBase RenderIFrame RenderFrame This more closely mimics the corresponding Element hierarchy and RenderFrameOwner would give us a place to put the common code.
Attachments
Add attachment
proposed patch, testcase, etc.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug