Bug 57889 – [chromium] stop putting results downloaded from WebKit Linux in chromium-linux-x86_64

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tony Chang]

[chromium] stop putting results downloaded from WebKit Linux in chromium-linux-x86_64

[Tony Chang]

Created attachment 88318 [details]
Patch

[Tony Chang]

Not sure if there's a better way to do this.  Suggestions welcome.

The problem was if we pass 'chromium-linux' to ChromiumLinuxPort.__init__, we automatically run self._determine_architecture.  Instead, force x86 by passing in the architecture in part of the port name.

[Dirk Pranke]

As I said over IRC, this is actually the right way to do this. The port names that get passed in by the rebaselining tool should be specific enough to unambiguously get a particular directory, and chromium-linux wasn't. It's the same reason we use 'chromium-win-win7' in this list instead of 'chromium-win'.

Patch LGTM.

[Mihai Parparita]

Comment on attachment 88318 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88318&action=review

> Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:538
> +                  new_file, baseline_fullpath)

Why the switch? copyfile takes source then destination.

[Tony Chang]

Created attachment 88348 [details]
Patch

[Tony Chang]

Comment on attachment 88318 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88318&action=review

>> Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:538
>> +                  new_file, baseline_fullpath)
> 
> Why the switch? copyfile takes source then destination.

Oh, you're right, it was correct.  I was confused since it was copying the file to /tmp.

[WebKit Commit Bot]

Comment on attachment 88348 [details]
Patch

Clearing flags on attachment: 88348

Committed r83009: <http://trac.webkit.org/changeset/83009>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.