WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
57869
REGRESSION (
r82734
): Links in Leaks Viewer's Recent Builds list don't work
https://bugs.webkit.org/show_bug.cgi?id=57869
Summary
REGRESSION (r82734): Links in Leaks Viewer's Recent Builds list don't work
Adam Roben (:aroben)
Reported
2011-04-05 11:50:07 PDT
To reproduce: 1. Go to <
http://build.webkit.org/LeaksViewer/
> 2. Click on a recent build The leaks from that build never load.
Attachments
Strip off /results.html from results URLs before trying to load leaks files from them
(2.08 KB, patch)
2011-04-05 11:59 PDT
,
Adam Roben (:aroben)
joepeck
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1
2011-04-05 11:50:29 PDT
r82734
changed the "view results" links to point to results.html. Leaks Viewer expects them to point to the directory that contains results.html. Should be easy to fix.
Adam Roben (:aroben)
Comment 2
2011-04-05 11:59:45 PDT
Created
attachment 88290
[details]
Strip off /results.html from results URLs before trying to load leaks files from them
Joseph Pecoraro
Comment 3
2011-04-05 12:33:48 PDT
Comment on
attachment 88290
[details]
Strip off /results.html from results URLs before trying to load leaks files from them View in context:
https://bugs.webkit.org/attachment.cgi?id=88290&action=review
> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:65 > + var url = step.urls["view results"]; > + buildInfo.url = self._buildbotBaseURL + url.replace(/\/results\.html$/, "") + "/";
If all the build bots point to ".../results.html" you only need to chop off the results.html part and not add the slash. But I think the current approach works well because it always ensures a slash at the end.
Adam Roben (:aroben)
Comment 4
2011-04-05 12:35:47 PDT
Comment on
attachment 88290
[details]
Strip off /results.html from results URLs before trying to load leaks files from them View in context:
https://bugs.webkit.org/attachment.cgi?id=88290&action=review
>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:65 >> + buildInfo.url = self._buildbotBaseURL + url.replace(/\/results\.html$/, "") + "/"; > > If all the build bots point to ".../results.html" you only need to chop off the results.html part and not add the slash. But I think the current approach works well because it always ensures a slash at the end.
That was exactly my thinking. (Old builds don't include the "/results.html", but of course that isn't a concern for RecentBuildsLoader.)
Adam Roben (:aroben)
Comment 5
2011-04-05 13:00:26 PDT
Committed
r82967
: <
http://trac.webkit.org/changeset/82967
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug