Bug 57865 - [Qt] Improve tests for QWebFrame::url() and related methods
Summary: [Qt] Improve tests for QWebFrame::url() and related methods
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other All
: P2 Normal
Assignee: Caio Marcelo de Oliveira Filho
URL:
Keywords: Qt
Depends on:
Blocks: 32723
  Show dependency tree / graph
 
Reported: 2011-04-05 11:18 PDT by Caio Marcelo de Oliveira Filho
Modified: 2011-04-06 02:38 PDT (History)
3 users (show)

See Also:

Attachments
Patch (9.92 KB, patch)
2011-04-05 11:21 PDT, Caio Marcelo de Oliveira Filho 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Caio Marcelo de Oliveira Filho 2011-04-05 11:18:52 PDT 
[Qt] Improve tests for QWebFrame::url() and related methods
Comment 1 Caio Marcelo de Oliveira Filho 2011-04-05 11:21:24 PDT 
Created attachment 88283 [details]
Patch
Comment 2 Caio Marcelo de Oliveira Filho 2011-04-05 11:26:57 PDT 
Kenneth and Benjamin, I've decided to split the test case improvements in a separated bug. The tests were outside of the scope of the original patch for fragment handling.

The idea is to document the existing url()/requestedUrl()/setUrl() and friends behavior better so we have more confidence when changing the innards of QWebFrame.
Comment 3 WebKit Commit Bot 2011-04-06 02:37:55 PDT 
Comment on attachment 88283 [details]
Patch

Clearing flags on attachment: 88283

Committed r83036: <http://trac.webkit.org/changeset/83036>
Comment 4 WebKit Commit Bot 2011-04-06 02:38:00 PDT 
All reviewed patches have been landed.  Closing bug.