Bug 57856 - Web Inspector: [Chromium] Add layout test for Summary view of detailed heap snapshots.
Summary: Web Inspector: [Chromium] Add layout test for Summary view of detailed heap s...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Mikhail Naganov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-05 09:51 PDT by Mikhail Naganov
Modified: 2011-04-06 01:05 PDT (History)
10 users (show)

See Also:


Attachments
patch (30.07 KB, patch)
2011-04-05 09:55 PDT, Mikhail Naganov
pfeldman: review+
mnaganov: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Naganov 2011-04-05 09:51:50 PDT
We need tests for this new panel. This change adds tests for the first one of its four views.
Comment 1 Mikhail Naganov 2011-04-05 09:55:20 PDT
Created attachment 88263 [details]
patch
Comment 2 Mikhail Naganov 2011-04-06 01:05:09 PDT
Manually committed http://trac.webkit.org/changeset/83031

2011-04-05  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Add layout test for Summary view of detailed heap snapshots.
        https://bugs.webkit.org/show_bug.cgi?id=57856

        Test: inspector/profiler/detailed-heapshots-summary.html

        * inspector/front-end/DataGrid.js:
        (WebInspector.DataGrid):
        * inspector/front-end/DetailedHeapshotGridNodes.js:
        (WebInspector.HeapSnapshotGridNode.prototype._populate.doPopulate):
        (WebInspector.HeapSnapshotGridNode.prototype._populate):
        (WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
        (WebInspector.HeapSnapshotGridNode.prototype.sort.doSort):
        (WebInspector.HeapSnapshotGridNode.prototype.sort):
        (WebInspector.HeapSnapshotDiffNode.prototype.populateChildren):
        * inspector/front-end/DetailedHeapshotView.js:
        (WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged):
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.doParse):
        (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):

2011-04-05  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Add layout test for Summary view of detailed heap snapshots.
        https://bugs.webkit.org/show_bug.cgi?id=57856

        * http/tests/inspector/inspector-test.js:
        (initialize_InspectorTest.):
        (initialize_InspectorTest):
        * inspector/profiler/detailed-heapshots-summary-expected.txt: Added.
        * inspector/profiler/detailed-heapshots-summary.html: Added.
        * inspector/profiler/detailed-heapshots-test.js: Added.
        * platform/chromium/inspector/profiler/detailed-heapshots-summary-expected.txt: Added.