Bug 57853 - DeleteButtonController is given invalid style
Summary: DeleteButtonController is given invalid style
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 50949
  Show dependency treegraph
Reported: 2011-04-05 08:53 PDT by Levi Weintraub
Modified: 2011-04-05 09:35 PDT (History)
4 users (show)

See Also:

Patch (1.66 KB, patch)
2011-04-05 09:08 PDT, Levi Weintraub
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Levi Weintraub 2011-04-05 08:53:07 PDT
DeleteButtonController::createDeletionUI() sets CSSPropertyWebkitUserModify to CSSValueNone, which is not a valid value for user modify. Instead, it should be CSSValueReadOnly.

I ran into an ASSERT_NOT_REACHED in WebCore::Node::rendererIsEditable() when trying to add the plaintext value to unicode-bidi for 50949. After my new CSS value is added, every test using the DeleteButtonController crashed the same way.

I can't reproduce this without the new CSS value. Anyone know why?
Comment 1 Levi Weintraub 2011-04-05 09:08:24 PDT
Created attachment 88245 [details]
Comment 2 Levi Weintraub 2011-04-05 09:34:52 PDT
Comment on attachment 88245 [details]

Clearing flags on attachment: 88245

Committed r82946: <http://trac.webkit.org/changeset/82946>
Comment 3 Levi Weintraub 2011-04-05 09:35:05 PDT
All reviewed patches have been landed.  Closing bug.