Bug 57846 - ORWT shouldn't generate diff files for tests without expected files
Summary: ORWT shouldn't generate diff files for tests without expected files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-05 07:38 PDT by Csaba Osztrogonác
Modified: 2011-04-06 09:07 PDT (History)
5 users (show)

See Also:


Attachments
proposed fix (1.45 KB, patch)
2011-04-05 07:43 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2011-04-05 07:38:12 PDT
Now old-run-webkit-tests creates a zero sized actual-result.txt,
and then generate a useless diff and a pretty diff file for all
tests without checked in expected file.

The original changeset was: http://trac.webkit.org/changeset/46607
Comment 1 Csaba Osztrogonác 2011-04-05 07:43:40 PDT
Created attachment 88231 [details]
proposed fix

With this modification won't break the original goal of
http://trac.webkit.org/changeset/46607 , links to the new 
test results will work, but we shouldn't generate useless 
zero bytes sized expected.txt and a diff and pretty diff file.
Comment 2 Csaba Osztrogonác 2011-04-05 07:46:22 PDT
Comment on attachment 88231 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=88231&action=review

> Tools/Scripts/old-run-webkit-tests:2113
> +    if ( !-f $expectedResultPath) {

ooops, an additional space typo. I'm going to fix it before landing.
Comment 3 Andras Becsi 2011-04-06 07:56:38 PDT
Comment on attachment 88231 [details]
proposed fix

LGTM.
Comment 4 Csaba Osztrogonác 2011-04-06 08:49:06 PDT
Landed in http://trac.webkit.org/changeset/83055
Comment 5 WebKit Review Bot 2011-04-06 09:07:58 PDT
http://trac.webkit.org/changeset/83055 might have broken WinCairo Debug (Build)