Bug 57840 - Switch from Vector<UChar> to StringBuilder in css/
Summary: Switch from Vector<UChar> to StringBuilder in css/
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nikolas Zimmermann
Depends on: 58420
  Show dependency treegraph
Reported: 2011-04-05 06:28 PDT by Nikolas Zimmermann
Modified: 2011-05-12 07:58 PDT (History)
2 users (show)

See Also:

Patch (21.39 KB, patch)
2011-04-05 06:30 PDT, Nikolas Zimmermann
no flags Details | Formatted Diff | Diff
Patch v2 (21.37 KB, patch)
2011-04-05 07:03 PDT, Nikolas Zimmermann
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2011-04-05 06:28:31 PDT
As discussed in bug 56099, we should deploy StringBuilder usage in WebCore where possible.
This bug addresses Source/WebCore/css.
Comment 1 Nikolas Zimmermann 2011-04-05 06:30:56 PDT
Created attachment 88218 [details]
Comment 2 WebKit Review Bot 2011-04-05 06:33:00 PDT
Attachment 88218 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style']" exit_code: 1

Source/WebCore/css/CSSOMUtils.h:42:  The parameter name "string" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 5 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Nikolas Zimmermann 2011-04-05 07:03:26 PDT
Created attachment 88222 [details]
Patch v2

Fix style isssue.
Comment 4 Nikolas Zimmermann 2011-04-08 23:31:28 PDT
Comment on attachment 88222 [details]
Patch v2

Removing r?. As discussed with Maciej, he prefers to optimize operator+ instead of having to change all callsites that append just 2 strings. I'll look into that.
Comment 5 Nikolas Zimmermann 2011-05-12 07:58:48 PDT
I'll rework the patch to avoid using makeString, it's not needed anymore, as operator+ is fast now.