Bug 57837 - Switch from Vector<UChar> to StringBuilder in accessibility/
Summary: Switch from Vector<UChar> to StringBuilder in accessibility/
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-05 06:09 PDT by Nikolas Zimmermann
Modified: 2011-04-05 06:38 PDT (History)
3 users (show)

See Also:


Attachments
Patch (5.08 KB, patch)
2011-04-05 06:11 PDT, Nikolas Zimmermann
no flags Details | Formatted Diff | Diff
Patch v2 (5.28 KB, patch)
2011-04-05 06:22 PDT, Nikolas Zimmermann
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2011-04-05 06:09:14 PDT
As discussed in bug 56099, we should deploy StringBuilder usage in WebCore where possible.
This bug addresses Source/WebCore/accessibility.
Comment 1 Nikolas Zimmermann 2011-04-05 06:11:54 PDT
Created attachment 88214 [details]
Patch
Comment 2 WebKit Review Bot 2011-04-05 06:16:43 PDT
Attachment 88214 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/8334317
Comment 3 Nikolas Zimmermann 2011-04-05 06:22:54 PDT
Created attachment 88216 [details]
Patch v2

Fix missing include, hard to notice on mac which does AllInOne builds.
Comment 4 Andreas Kling 2011-04-05 06:28:43 PDT
Comment on attachment 88216 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=88216&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1185
>          String nameFragment = accessibleNameForNode(idElement);

Seems like we don't need this local anymore.
Comment 5 Nikolas Zimmermann 2011-04-05 06:38:30 PDT
Fixed Andreas suggestion! Landed in r82934.