Bug 57833 - Web Inspector: The list of Database entries is empty if the page opens a database just before Web Inspector
Summary: Web Inspector: The list of Database entries is empty if the page opens a data...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-05 05:43 PDT by Ilya Tikhonovsky
Modified: 2011-04-15 22:32 PDT (History)
10 users (show)

See Also:

Attachments
[patch] initial version (7.02 KB, patch)
2011-04-14 05:42 PDT, Ilya Tikhonovsky 		pfeldman: review-
Details | Formatted Diff | Diff
[patch] second version (6.38 KB, patch)
2011-04-14 06:19 PDT, Ilya Tikhonovsky 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2011-04-05 05:43:31 PDT 
%subj%
Comment 1 Ilya Tikhonovsky 2011-04-14 05:42:15 PDT 
Created attachment 89564 [details]
[patch] initial version
Comment 2 Pavel Feldman 2011-04-14 05:47:27 PDT 
Comment on attachment 89564 [details]
[patch] initial version

View in context: https://bugs.webkit.org/attachment.cgi?id=89564&action=review

> Source/WebCore/inspector/InspectorDatabaseAgent.cpp:265
> +    if (m_enabled)

m_enabled = true ?

> Source/WebCore/inspector/InspectorDatabaseAgent.cpp:275
> +    if (!m_enabled)

m_enabled = false ?
Comment 3 Ilya Tikhonovsky 2011-04-14 06:19:44 PDT 
Created attachment 89571 [details]
[patch] second version

comments addressed
Comment 4 Ilya Tikhonovsky 2011-04-14 06:36:11 PDT 
Comment on attachment 89571 [details]
[patch] second version

Clearing flags on attachment: 89571

Committed r83849: <http://trac.webkit.org/changeset/83849>
Comment 5 Ilya Tikhonovsky 2011-04-14 06:36:19 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Ilya Tikhonovsky 2011-04-15 22:32:23 PDT 
Committed r84080: <http://trac.webkit.org/changeset/84080>