What steps will reproduce the problem? At a web page like "http://news.ycombinator.com/item?id=1968304" I modified a <p> element, and added the attribute id='p12345' i then typed in the following code into the console: range = document.createRange(); referenceNode = document.getElementById('p12345').firstChild; range.selectNode(referenceNode); range.setStart(referenceNode, 89 ); range.setEnd(referenceNode, 89 + 5 ); range.deleteContents(); span = range.startContainer.ownerDocument.createElement('span'); span.innerHTML = 'test'; range.insertNode(span); after running the above code, the html view updates, but the inspector does not. it truncates after the insertion point. What is the expected result? the html in the inspector should properly update. What happens instead? after running the above code, the html view updates, but the inspector does not. it truncates after the insertion point. Upstreaming http://code.google.com/p/chromium/issues/detail?id=65424 with the code snippet fixed.
Created attachment 88227 [details] [PATCH] Suggested fix
Created attachment 88234 [details] [PATCH] Added a test case to an existing test instead of a new one
Created attachment 88252 [details] [PATCH] Simplified patch, as suggested by pfeldman
Comment on attachment 88252 [details] [PATCH] Simplified patch, as suggested by pfeldman View in context: https://bugs.webkit.org/attachment.cgi?id=88252&action=review > Source/WebCore/inspector/InspectorDOMAgent.cpp:1100 > + m_childrenRequested.add(bind(container, nodesMap)); Please remove all the other calls to m_childredRequested.add
Created attachment 88267 [details] [PATCH] Comment addressed
Comment on attachment 88267 [details] [PATCH] Comment addressed View in context: https://bugs.webkit.org/attachment.cgi?id=88267&action=review > Source/WebCore/inspector/InspectorDOMAgent.cpp:1094 > + return buildArrayForContainerChildren(container, 1, nodesMap); Can you rewrite this if block to avoid the recursive call here?
Committed r83037: <http://trac.webkit.org/changeset/83037>