Bug 57815 – Remove duplicate API from WKContext

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

Remove duplicate API from WKContext

[Sam Weinig]

Created attachment 88185 [details]
Patch

[WebKit Review Bot]

Attachment 88185 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style']" exit_code: 1

Source/WebKit2/WebProcess/WebProcess.h:122:  The parameter name "cachesToClear" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brian Weinstein]

Comment on attachment 88185 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88185&action=review

> Source/WebKit2/WebProcess/WebProcess.messages.in:59
> +    DownloadRequest(uint64_t downloadID, uint64_t initiatingPageID, WebCore::ResourceRequest request)

Does removing the void change the code in any way? I see a couple voids above this (Start and StopMemorySampler), should those be changed too?

[Sam Weinig]

(In reply to comment #3)
> (From update of attachment 88185 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=88185&action=review
> 
> > Source/WebKit2/WebProcess/WebProcess.messages.in:59
> > +    DownloadRequest(uint64_t downloadID, uint64_t initiatingPageID, WebCore::ResourceRequest request)
> 
> Does removing the void change the code in any way? I see a couple voids above this (Start and StopMemorySampler), should those be changed too?

No, it was just wrong.  The void has no meaning in that syntax.

[Sam Weinig]

Landed in r82906.

[Csaba Osztrogonác]

(In reply to comment #5)
> Landed in r82906.

And a buildfix landed in http://trac.webkit.org/changeset/82907

:(

[Darin Adler]

This wont work when people use newer compilers, because on some of them, UNUSED_PARAM actually warns if the variable is used.

So the UNUSED_PARAM needs to be inside the conditional, not unconditional. I also suggest using UNUSED_PARAM on cachesToClear, not on the local variable, and putting the local variable inside the conditional too.

[Csaba Osztrogonác]

(In reply to comment #7)
> This wont work when people use newer compilers, because on some of them, UNUSED_PARAM actually warns if the variable is used.
> 
> So the UNUSED_PARAM needs to be inside the conditional, not unconditional. I also suggest using UNUSED_PARAM on cachesToClear, not on the local variable, and putting the local variable inside the conditional too.

Thanks for the advice, I didn't know if it can cause problem 
with newer compilers.

I filed a new bug and uploaded a patch based on your suggestion: https://bugs.webkit.org/show_bug.cgi?id=57940