Bug 57810 - [V8] Keep dirty primitive CSS values alive
Summary: [V8] Keep dirty primitive CSS values alive
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-04 17:35 PDT by Vitaly Repeshko
Modified: 2011-04-05 14:20 PDT (History)
2 users (show)

See Also:

Attachments
patch (3.61 KB, patch)
2011-04-04 17:41 PDT, Vitaly Repeshko 		abarth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vitaly Repeshko 2011-04-04 17:35:20 PDT 
[V8] Keep dirty primitive CSS values alive

This should make fast/dom/StyleSheet/gc-inline-style-cssvalues.html pass again.
Comment 1 Vitaly Repeshko 2011-04-04 17:41:53 PDT 
Created attachment 88174 [details]
patch
Comment 2 anton muhin 2011-04-05 02:27:40 PDT 
Comment on attachment 88174 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88174&action=review

LGTM

> Source/WebCore/bindings/v8/V8GCController.cpp:368
> +                Vector<v8::Persistent<v8::Value> > values;

nit: may you add a space between < and v8::Persistent?
Comment 3 Vitaly Repeshko 2011-04-05 14:20:53 PDT 
	M	LayoutTests/ChangeLog
	M	LayoutTests/platform/chromium/test_expectations.txt
	M	Source/WebCore/ChangeLog
	M	Source/WebCore/bindings/v8/V8GCController.cpp
Committed r82981