RESOLVED FIXED 57807
new-run-webkit-tests: stop driver on windows properly 
https://bugs.webkit.org/show_bug.cgi?id=57807
Summary new-run-webkit-tests: stop driver on windows properly
Dirk Pranke
Reported 2011-04-04 16:44:25 PDT
new-run-webkit-tests: stop driver on windows properly
Attachments
Patch (3.13 KB, patch)
2011-04-04 16:51 PDT, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
add unit test (5.06 KB, patch)
2011-04-04 17:11 PDT, Dirk Pranke 		tony: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2011-04-04 16:51:35 PDT
Created attachment 88160 [details] Patch
Dirk Pranke
Comment 2 2011-04-04 16:52:46 PDT
Comment on attachment 88160 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=88160&action=review > Tools/Scripts/webkitpy/layout_tests/port/chromium.py:-524 > - # http://bugs.python.org/issue1731717 I've removed the comments about poll(), because it looks like it only applied to 2.4 and if we weren't reliably calling _proc.wait().
Dirk Pranke
Comment 3 2011-04-04 17:11:50 PDT
Created attachment 88168 [details] add unit test
Dirk Pranke
Comment 4 2011-04-04 17:14:51 PDT
Comment on attachment 88168 [details] add unit test View in context: https://bugs.webkit.org/attachment.cgi?id=88168&action=review > Tools/Scripts/webkitpy/layout_tests/port/chromium.py:-524 > - # http://bugs.python.org/issue1731717 I've deleted this comment about poll()'s thread safety because it looks like it was only relevant on Python 2.4 and when we weren't reliably calling proc.wait().
Tony Chang
Comment 5 2011-04-05 09:16:55 PDT
Comment on attachment 88168 [details] add unit test View in context: https://bugs.webkit.org/attachment.cgi?id=88168&action=review Did you test this on win32 python and cygwin python? > Tools/Scripts/webkitpy/layout_tests/port/chromium.py:337 > + self.KILL_TIMEOUT = 3.0 Nit: pull this out of __init__? You can still refer to it with self.KILL_TIMEOUT and shadow it in a test by setting driver.KILL_TIMEOUT.
Dirk Pranke
Comment 6 2011-04-06 18:55:37 PDT
I will move it out of the __init__. I'm stil banging on this one and some related bug fixes intended to stabilize the win ports, so there may or may not be additional changes for this patch.
Dirk Pranke
Comment 7 2011-04-09 17:31:05 PDT
Committed r83384: <http://trac.webkit.org/changeset/83384>
Note You need to log in before you can comment on or make changes to this bug.