Bug 57778 – Create SnowLeopard Debug builder and tester

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Lucas Forschler]

per Maciej, we need a SnowLeopard Debug Test Bot.  This requires a SL Debug builder.  We currently build SL Debug using the leaks bot.  We will need to turn the current leaks bot into a test only bot, as we are adding a SL Debug build-only bot.
I believe we should wait until verifying the new debug builder is functional before changing the current leak bot functionality.

[Lucas Forschler]

Created attachment 88109 [details]
Patch for updating the webkit buildbot master

patch to update the config.json for the buildbot master.  This will require a master restart.

[WebKit Review Bot]

Comment on attachment 88109 [details]
Patch for updating the webkit buildbot master

Rejecting attachment 88109 [details] from review queue.

[e-mail] does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.

[WebKit Review Bot]

Attachment 88109 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style']" exit_code: 1

Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Eric Seidel (no email)]

Comment on attachment 88109 [details]
Patch for updating the webkit buildbot master

OK.

[WebKit Commit Bot]

Comment on attachment 88109 [details]
Patch for updating the webkit buildbot master

Rejecting attachment 88109 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'apply-..." exit_code: 2

Last 500 characters of output:
'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1

Parsed 2 diffs from patch file(s).
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/BuildSlaveSupport/build.webkit.org-config/config.json
Hunk #3 FAILED at 241.
1 out of 4 hunks FAILED -- saving rejects to file Tools/BuildSlaveSupport/build.webkit.org-config/config.json.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/8507755

[Lucas Forschler]

Created attachment 93338 [details]
Add SnowLeopard Debug builder and tester

retrying, the original patch never made it through somehow.

[Stephanie Lewis]

Comment on attachment 93338 [details]
Add SnowLeopard Debug builder and tester

View in context: https://bugs.webkit.org/attachment.cgi?id=93338&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:24
>                      	

I think you met mac-snowleopard?

[WebKit Review Bot]

Attachment 93338 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/BuildSlaveSupport/build.webkit.org-c..." exit_code: 1

Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Lucas Forschler]

Created attachment 93342 [details]
Add snowleopard bots

update...typo in last patch.

[WebKit Review Bot]

Attachment 93342 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/BuildSlaveSupport/build.webkit.org-c..." exit_code: 1

Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 93342 [details]
Add snowleopard bots

Clearing flags on attachment: 93342

Committed r86386: <http://trac.webkit.org/changeset/86386>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[William Siegrist]

You seem to both apple-macpro-8 and -9, as well as apple-xserve-8 and -9. I tried changing the macpros to xserves, but you still reference a builder called "SnowLeopard Intel Debug (WebKit2 Tests)" that does not exist.

[Lucas Forschler]

Created attachment 93376 [details]
Fix the bot names, and add the builder

the previous patch incorrectly mixed the bot names (macpro = xserve)
Also, left out a WK2 config portion.

[WebKit Commit Bot]

Comment on attachment 93376 [details]
Fix the bot names, and add the builder

Clearing flags on attachment: 93376

Committed r86411: <http://trac.webkit.org/changeset/86411>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 93376 [details]:

security/block-test.html bug 55741 (authors: [e-mail], [e-mail], and [e-mail])
The commit-queue is continuing to process your patch.

[William Siegrist]

apple-xserve-9 is assigned to two builders: "SnowLeopard Intel Debug (Build)" and "SnowLeopard Intel Debug (WebKit2 Tests)". Was that intentional?

[Lucas Forschler]

It was intentional, as I don't have another machine available to bring up, and wanted to get results for these bots going.

However, I think I should be able to bring up another bot next week if it falls too far behind.