Bug 57772 - Implement various "NotImplemented" file handling functions
Summary: Implement various "NotImplemented" file handling functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit wx (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-04 11:57 PDT by Malcolm MacLeod
Modified: 2011-04-04 12:16 PDT (History)
2 users (show)

See Also:


Attachments
Temporary files handling patch (3.10 KB, patch)
2011-04-04 11:57 PDT, Malcolm MacLeod
kevino: review+
kevino: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Malcolm MacLeod 2011-04-04 11:57:50 PDT
Created attachment 88090 [details]
Temporary files handling patch

Various file handling functions, mostly relating to temporary files are not yet implemented on the wx port. This prevents PDF embedding (embed/object tag) from working correctly (on some machines?) as well as possibly interfering with various other functionality as well.
The attached patch implements these functions allowing PDF embedding to work correctly.
Comment 1 WebKit Review Bot 2011-04-04 12:03:57 PDT
Attachment 88090 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style']" exit_code: 1

Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 2 Kevin Ollivier 2011-04-04 12:16:58 PDT
Landed in r82851, thanks!