Split run storage out from BidiResolver into a new BidiRunList class
Created attachment 88079 [details]
Created attachment 88081 [details]
This patch was based on top of the patch for bug 57727, but is not technically dependent on it.
In my first draft of this patch, I went all the way and tried to fix the tangled relationship between BidiResolver and InlineIterator. But I backed off in hopes of making this patch easier to review.
The portion of this patch dealing with the creation of BidiRunList is *entirely* just moving code. I highlighted the one line change in removing the m_emptyRun = true from deleteRuns() in the ChangeLog.
The other portion of this patch is fixing up the callers to deal with these methods being removed from BidiResolver, and is again no functional change. I did clean up the argument passing a little now that the storage isn't strictly part of BidiResolver.
Hopefully you will all find this a no-brainer to review.
Comment on attachment 88081 [details]
It seems like you've forgot to include BidiRunList.h here.
Created attachment 88092 [details]
Comment on attachment 88092 [details]
looks sane to me.
Created attachment 88664 [details]
Patch for landing
Comment on attachment 88664 [details]
Patch for landing
Rejecting attachment 88664 [details] from commit-queue.
Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'apply-..." exit_code: 2
Last 500 characters of output:
patching file Source/WebCore/platform/graphics/GraphicsContext.cpp
patching file Source/WebCore/platform/text/BidiResolver.h
patching file Source/WebCore/platform/text/BidiRunList.h
patching file Source/WebCore/rendering/InlineIterator.h
patching file Source/WebCore/rendering/RenderBlock.h
patching file Source/WebCore/rendering/RenderBlockLineLayout.cpp
Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1
Full output: http://queues.webkit.org/results/8344794
Committed r83240: <http://trac.webkit.org/changeset/83240>