Bug 57763 - Web Inspector: [Extensions API] remove inspectedPage.* events
Summary: Web Inspector: [Extensions API] remove inspectedPage.* events
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-04 10:23 PDT by Andrey Kosyakov
Modified: 2011-04-06 01:27 PDT (History)
9 users (show)

See Also:


Attachments
patch (8.71 KB, patch)
2011-04-04 10:31 PDT, Andrey Kosyakov
no flags Details | Formatted Diff | Diff
patch (12.77 KB, patch)
2011-04-05 09:29 PDT, Andrey Kosyakov
yurys: review-
Details | Formatted Diff | Diff
patch (12.64 KB, patch)
2011-04-05 10:08 PDT, Andrey Kosyakov
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2011-04-04 10:23:45 PDT
- remove onDOMContentLoaded & onLoaded events (native browser extensions should be used instead)
- moved onNavigated to webInspecor.resources
Comment 1 Andrey Kosyakov 2011-04-04 10:31:21 PDT
Created attachment 88077 [details]
patch
Comment 2 Yury Semikhatsky 2011-04-05 01:35:36 PDT
Comment on attachment 88077 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88077&action=review

> Source/WebCore/inspector/front-end/ExtensionAPI.js:114
> +    this.onNavigated = new EventSink("inspectedURLChanged");

Is there a test for this event?

> Source/WebCore/inspector/front-end/ExtensionAPISchema.json:170
> +            "name": "callback",

Looks unrelated to this change.
Comment 3 Andrey Kosyakov 2011-04-05 09:29:27 PDT
Created attachment 88253 [details]
patch

- the schema change is intended (just a drive-by fix to bring it in-sync with the code)
- added test
Comment 4 Yury Semikhatsky 2011-04-05 09:59:59 PDT
Comment on attachment 88253 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88253&action=review

> LayoutTests/inspector/extensions/extensions-events-expected.txt:8
> +Navigated to: file:///E:/src/gchromium/src/third_party/WebKit/LayoutTests/inspector/extensions/extensions-events.html?navigated

Test result is source-path dependent, r- for this.
Comment 5 Andrey Kosyakov 2011-04-05 10:08:00 PDT
Created attachment 88266 [details]
patch

oops, thanks for spotting this!
Comment 6 Andrey Kosyakov 2011-04-06 01:27:28 PDT
Manually committed r83033: http://trac.webkit.org/changeset/83033