Bug 57758 - [Cairo] Memory leak in RefPtrCairo
Summary: [Cairo] Memory leak in RefPtrCairo
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2011-04-04 08:55 PDT by Martin Robinson
Modified: 2011-04-04 16:19 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.37 KB, patch)
2011-04-04 09:12 PDT, Martin Robinson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2011-04-04 08:55:46 PDT 
template<> void derefIfNotNull(cairo_font_face_t* ptr)
62      {
63          if (LIKELY(ptr != 0))
64              cairo_font_face_reference(ptr);
65      }

Line 64 should certainly read cairo_font_face_destroy.
Comment 1 Martin Robinson 2011-04-04 09:12:26 PDT 
Created attachment 88067 [details]
Patch
Comment 2 Xan Lopez 2011-04-04 16:06:10 PDT 
Comment on attachment 88067 [details]
Patch

wow, oops?
Comment 3 Martin Robinson 2011-04-04 16:19:20 PDT 
Comment on attachment 88067 [details]
Patch

Clearing flags on attachment: 88067

Committed r82890: <http://trac.webkit.org/changeset/82890>
Comment 4 Martin Robinson 2011-04-04 16:19:24 PDT 
All reviewed patches have been landed.  Closing bug.