Bug 57749 - Web Inspector: Highlighted search tokens would not be shown on long lines in the text viewer
Summary: Web Inspector: Highlighted search tokens would not be shown on long lines in ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-04 02:52 PDT by Andrey Adaikin
Modified: 2011-04-04 05:40 PDT (History)
10 users (show)

See Also:

Attachments
Patch (4.40 KB, patch)
2011-04-04 04:25 PDT, Andrey Adaikin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Adaikin 2011-04-04 02:52:13 PDT 
Search tokens may not be shown if the editor is busy with highlighting the lines (i.e. scrollIntoViewIfNeeded() is not called).
Comment 1 Andrey Adaikin 2011-04-04 04:25:51 PDT 
Created attachment 88048 [details]
Patch
Comment 2 Yury Semikhatsky 2011-04-04 05:17:44 PDT 
Comment on attachment 88048 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=88048&action=review

> Source/WebCore/inspector/front-end/TextViewer.js:1029
> +            if (this._rangeToMark && this._rangeToMark.startLine === lineNumber)

Consider refactoring this method and extracting syntax highlight and search result highlight into separate methods.
Comment 3 Pavel Podivilov 2011-04-04 05:40:23 PDT 
Comment on attachment 88048 [details]
Patch

Clearing flags on attachment: 88048

Committed r82824: <http://trac.webkit.org/changeset/82824>
Comment 4 Pavel Podivilov 2011-04-04 05:40:32 PDT 
All reviewed patches have been landed.  Closing bug.