WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
VERIFIED FIXED
5774
Failed assertion `!eventDispatchForbidden()' in dom_nodeimpl.cpp:892
https://bugs.webkit.org/show_bug.cgi?id=5774
Summary
Failed assertion `!eventDispatchForbidden()' in dom_nodeimpl.cpp:892
mitz
Reported
2005-11-18 14:35:14 PST
With the fix for
bug 5629
in place, the assert in dispatchSubtreeModifiedEvent() actually fails when opening the URL. Backtrace: #3 0x0183cf28 in DOM::NodeImpl::dispatchSubtreeModifiedEvent (this=0xcac35f0, sendChildrenChanged=false) at WebCore/khtml/xml/dom_nodeimpl.cpp:892 #4 0x0182b0bc in DOM::NamedAttrMapImpl::addAttribute (this=0xca7ca80, attr=0xca7cab0) at WebCore/khtml/xml/dom_elementimpl.cpp:1051 #5 0x0182e70c in DOM::ElementImpl::setAttribute (this=0xcac35f0, name=@0x1a41ab8, value=0xcc0fb10, exceptioncode=@0xbfffd9a8) at WebCore/khtml/xml/dom_elementimpl.cpp:394 #6 0x0182e7d8 in DOM::ElementImpl::setAttribute (this=0xcac35f0, name=@0x1a41ab8, value=@0xbfffda14) at WebCore/khtml/xml/dom_elementimpl.cpp:308 #7 0x017535d8 in DOM::HTMLBodyElementImpl::insertedIntoDocument (this=0xcac35f0) at WebCore/ khtml/html/html_baseimpl.cpp:187 #8 0x01835fa4 in DOM::ContainerNodeImpl::addChild (this=0xcac2df0, newChild=0xcac35f0) at WebCore/khtml/xml/dom_nodeimpl.cpp:2528 #9 0x0179f620 in HTMLParser::insertNode (this=0xcc1c6b0, n=0xcac35f0, flat=false) at WebCore/ khtml/html/htmlparser.cpp:274
Attachments
Call enableEventDispatch() sooner.
(5.12 KB, patch)
2005-11-18 18:27 PST
,
David Harrison
timothy
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
mitz
Comment 1
2005-11-18 15:06:12 PST
Here the problem is that during addChild(), HTMLBodyElementImpl::insertedIntoDocument() calls setAttribute() which wants to dispatch an event.
David Harrison
Comment 2
2005-11-18 15:57:34 PST
Am working on this.
David Harrison
Comment 3
2005-11-18 18:27:50 PST
Created
attachment 4729
[details]
Call enableEventDispatch() sooner. Call enableEventDispatch() sooner, when basic dom mods are done.
Timothy Hatcher
Comment 4
2005-11-18 18:32:58 PST
Comment on
attachment 4729
[details]
Call enableEventDispatch() sooner. r=me
David Harrison
Comment 5
2005-11-18 18:36:34 PST
Committed.
mitz
Comment 6
2005-11-19 00:52:32 PST
That was fast!
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug