Bug 5774 – Failed assertion `!eventDispatchForbidden()' in dom_nodeimpl.cpp:892

• Status: VERIFIED
• Resolution: FIXED
• Component: DOM

With the fix for bug 5629 in place, the assert in dispatchSubtreeModifiedEvent() actually fails when 
opening the URL. Backtrace:
#3  0x0183cf28 in DOM::NodeImpl::dispatchSubtreeModifiedEvent (this=0xcac35f0, 
sendChildrenChanged=false) at WebCore/khtml/xml/dom_nodeimpl.cpp:892
#4  0x0182b0bc in DOM::NamedAttrMapImpl::addAttribute (this=0xca7ca80, attr=0xca7cab0) at 
WebCore/khtml/xml/dom_elementimpl.cpp:1051
#5  0x0182e70c in DOM::ElementImpl::setAttribute (this=0xcac35f0, name=@0x1a41ab8, 
value=0xcc0fb10, exceptioncode=@0xbfffd9a8) at WebCore/khtml/xml/dom_elementimpl.cpp:394
#6  0x0182e7d8 in DOM::ElementImpl::setAttribute (this=0xcac35f0, name=@0x1a41ab8, 
value=@0xbfffda14) at WebCore/khtml/xml/dom_elementimpl.cpp:308
#7  0x017535d8 in DOM::HTMLBodyElementImpl::insertedIntoDocument (this=0xcac35f0) at WebCore/
khtml/html/html_baseimpl.cpp:187
#8  0x01835fa4 in DOM::ContainerNodeImpl::addChild (this=0xcac2df0, newChild=0xcac35f0) at 
WebCore/khtml/xml/dom_nodeimpl.cpp:2528
#9  0x0179f620 in HTMLParser::insertNode (this=0xcc1c6b0, n=0xcac35f0, flat=false) at WebCore/
khtml/html/htmlparser.cpp:274

Here the problem is that during addChild(), HTMLBodyElementImpl::insertedIntoDocument() calls 
setAttribute() which wants to dispatch an event.

[David Harrison]

Am working on this.

[David Harrison]

Created attachment 4729 [details]
Call enableEventDispatch() sooner.

Call enableEventDispatch() sooner, when basic dom mods are done.

[Timothy Hatcher]

Comment on attachment 4729 [details]
Call enableEventDispatch() sooner.

r=me

[David Harrison]

Committed.

That was fast!