RESOLVED FIXED 57726
Teach InlineIterator how to work from any root, not just a RenderBlock 
https://bugs.webkit.org/show_bug.cgi?id=57726
Summary Teach InlineIterator how to work from any root, not just a RenderBlock
Eric Seidel (no email)
Reported 2011-04-03 03:19:44 PDT
Teach InlineIterator how to work from any root, not just a RenderBlock
Attachments
Patch (7.09 KB, patch)
2011-04-03 03:22 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2011-04-03 03:22:32 PDT
Created attachment 88003 [details] Patch
Ryosuke Niwa
Comment 2 2011-04-03 03:57:20 PDT
Comment on attachment 88003 [details] Patch Doesn't InlineIterator currently assume to be working on RenderBlock? It seems like we should assert that we're only passing RenderBlock before you make the behavioral change.
Eric Seidel (no email)
Comment 3 2011-04-03 04:03:38 PDT
It never uses it as a RenderBlock. It's just a pointer to where to start/stop walking.
Ryosuke Niwa
Comment 4 2011-04-03 04:05:45 PDT
Comment on attachment 88003 [details] Patch I see. m_root is never used other than being compared with other pointers. Okay, the change looks sane to me.
WebKit Commit Bot
Comment 5 2011-04-03 05:38:00 PDT
Comment on attachment 88003 [details] Patch Clearing flags on attachment: 88003 Committed r82793: <http://trac.webkit.org/changeset/82793>
WebKit Commit Bot
Comment 6 2011-04-03 05:38:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.