Bug 57726 - Teach InlineIterator how to work from any root, not just a RenderBlock
Summary: Teach InlineIterator how to work from any root, not just a RenderBlock
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 50912
  Show dependency tree / graph
 
Reported: 2011-04-03 03:19 PDT by Eric Seidel (no email)
Modified: 2011-04-03 05:38 PDT (History)
4 users (show)

See Also:

Attachments
Patch (7.09 KB, patch)
2011-04-03 03:22 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2011-04-03 03:19:44 PDT 
Teach InlineIterator how to work from any root, not just a RenderBlock
Comment 1 Eric Seidel (no email) 2011-04-03 03:22:32 PDT 
Created attachment 88003 [details]
Patch
Comment 2 Ryosuke Niwa 2011-04-03 03:57:20 PDT 
Comment on attachment 88003 [details]
Patch

Doesn't InlineIterator currently assume to be working on RenderBlock?  It seems like we should assert that we're only passing RenderBlock before you make the behavioral change.
Comment 3 Eric Seidel (no email) 2011-04-03 04:03:38 PDT 
It never uses it as a RenderBlock.  It's just a pointer to where to start/stop walking.
Comment 4 Ryosuke Niwa 2011-04-03 04:05:45 PDT 
Comment on attachment 88003 [details]
Patch

I see. m_root is never used other than being compared with other pointers. Okay, the change looks sane to me.
Comment 5 WebKit Commit Bot 2011-04-03 05:38:00 PDT 
Comment on attachment 88003 [details]
Patch

Clearing flags on attachment: 88003

Committed r82793: <http://trac.webkit.org/changeset/82793>
Comment 6 WebKit Commit Bot 2011-04-03 05:38:04 PDT 
All reviewed patches have been landed.  Closing bug.