Bug 57712 - "Search in Spotlight" broken in WebKit2
Summary: "Search in Spotlight" broken in WebKit2
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Sam Weinig
Depends on:
Reported: 2011-04-02 15:15 PDT by Sam Weinig
Modified: 2011-04-02 17:21 PDT (History)
5 users (show)

See Also:

Patch (6.99 KB, patch)
2011-04-02 15:21 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (6.73 KB, patch)
2011-04-02 16:05 PDT, Sam Weinig
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2011-04-02 15:15:32 PDT
"Search in Spotlight" broken in WebKit2
Comment 1 Sam Weinig 2011-04-02 15:21:55 PDT
Created attachment 87987 [details]
Comment 2 Sam Weinig 2011-04-02 15:25:24 PDT
There were two options for addressing this:

1) Proxy call to the search with spotlight to the UIProcess.
2) Add selected text to the context menu state sent to the UIProcess for each context menu.

I implemented 1. Though 2 would be easy as well.
Comment 3 Early Warning System Bot 2011-04-02 15:32:04 PDT
Attachment 87987 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8185550
Comment 4 Build Bot 2011-04-02 15:44:57 PDT
Attachment 87987 [details] did not build on win:
Build output: http://queues.webkit.org/results/8185551
Comment 5 Sam Weinig 2011-04-02 16:05:26 PDT
Created attachment 87988 [details]
Comment 6 Oliver Hunt 2011-04-02 16:07:50 PDT
Comment on attachment 87988 [details]

r=me, you're taking after darin with change + refactoring :P
Comment 7 Sam Weinig 2011-04-02 16:19:56 PDT
Committed r82779: <http://trac.webkit.org/changeset/82779>
Comment 8 WebKit Review Bot 2011-04-02 17:21:32 PDT
http://trac.webkit.org/changeset/82779 might have broken Qt Linux Release
The following tests are not passing: