Fix style drawControl and drawComplexControl prototype
Created attachment 87983 [details] Patch
Comment on attachment 87983 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87983&action=review > Source/WebCore/platform/qt/QtMobileWebStyle.h:31 > + void drawControl(ControlElement, const QStyleOption*, QPainter*, const QWidget*) const; > + void drawComplexControl(ComplexControl, const QStyleOptionComplex*, QPainter*, const QWidget*) const; You are changing the default value, diego. It goes beyond style fixes :)
So it's r- no?
(In reply to comment #3) > So it's r- no? Not necesseraly. No everything needs to be r- if the contributor is a committer and patch has an issue. I r+ and expressed my concern, so it is just a matter of fixing it before landing.
(In reply to comment #4) > (In reply to comment #3) > > So it's r- no? > > Not necesseraly. No everything needs to be r- if the contributor is a committer and patch has an issue. I r+ and expressed my concern, so it is just a matter of fixing it before landing. Also it seems this default value is not used, since it did not break stuff to diego. So I do not really care this time.
Comment on attachment 87983 [details] Patch Let's cq+...
Comment on attachment 87983 [details] Patch Rejecting attachment 87983 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'apply-..." exit_code: 2 Last 500 characters of output: Scripts/svn-apply', u'--reviewer', u'Antonio Gomes', u'--fo..." exit_code: 1 Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/platform/qt/QtMobileWebStyle.h Hunk #1 FAILED at 27. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/platform/qt/QtMobileWebStyle.h.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Antonio Gomes', u'--fo..." exit_code: 1 Full output: http://queues.webkit.org/results/8185955
Thanks guys. I will commit it manually.
Fixed at r83047