[Qt] Radio buttons are showing wrong with mobile theme

[Diego Gonzalez]

Radio buttons are shown wrong in case painting in a wide area 
like in: http://www.amw.com/missing_persons/search.cfm

[Diego Gonzalez]

Created attachment 87977 [details]
Screenshot showing the bug

[Diego Gonzalez]

Created attachment 87978 [details]
Screenshot after patch

[Diego Gonzalez]

Created attachment 87979 [details]
Patch

[Antonio Gomes]

Comment on attachment 87979 [details]
Patch

side =! size?

[Eric Seidel (no email)]

Comment on attachment 87979 [details]
Patch

How do we test this?

[Antonio Gomes]

(In reply to comment #5)
> (From update of attachment 87979 [details])
> How do we test this?

it is not tested, afaik.

[Csaba Osztrogonác]

Comment on attachment 87979 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=87979&action=review

AFAIK we can test it, only if QT_MOBILE_THEME is true, but it isn't set by default.

Please fix the typo and the variable name before landing, otherwise LGTM, r=me.

> Source/WebCore/platform/qt/QtMobileWebStyle.cpp:92
> +    // get minor size to do not paint a wide elipse
> +    qreal side = qMin(size.width(), size.height());

// ... ellipse ...
radioButtonSize would be better name

> Source/WebCore/platform/qt/QtMobileWebStyle.cpp:94
> +    QRect rect = QRect(QPoint(1, 1), QSize(side - 2, side - 2));

ditto

[WebKit Review Bot]

http://trac.webkit.org/changeset/83043 might have broken GTK Linux 64-bit Debug

[Diego Gonzalez]

(In reply to comment #8)
> http://trac.webkit.org/changeset/83043 might have broken GTK Linux 64-bit Debug

I was not related with this patch

[Diego Gonzalez]

Fixed at r83043