RESOLVED FIXED 57704
Remove AbstractStep._run_script and move script names to ports.py 
https://bugs.webkit.org/show_bug.cgi?id=57704
Summary Remove AbstractStep._run_script and move script names to ports.py
Patrick R. Gansterer
Reported 2011-04-02 04:09:04 PDT
Remove AbstractStep._run_script and move script names to ports.py
Attachments
Patch (10.97 KB, patch)
2011-04-02 04:14 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2011-04-02 04:14:32 PDT
Created attachment 87974 [details] Patch
Eric Seidel (no email)
Comment 2 2011-04-02 04:48:23 PDT
Comment on attachment 87974 [details] Patch Sigh. Well, this is a good thing to do, but there are two troubles I should point outin this patch. 1. ports.py should die. class methods aren't long-term scaleable. We have a port.py over in layout_tests which we eventually want to merge it with/replace it with. Second, run_and_throw_if_fail also is deprecated and should die. :) That said, this is a great change to get rid of a fixme! I'm glad to see you workign on webkitpy!
WebKit Commit Bot
Comment 3 2011-04-02 05:15:59 PDT
Comment on attachment 87974 [details] Patch Clearing flags on attachment: 87974 Committed r82771: <http://trac.webkit.org/changeset/82771>
WebKit Commit Bot
Comment 4 2011-04-02 05:16:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.