Bug 57704 - Remove AbstractStep._run_script and move script names to ports.py
Summary: Remove AbstractStep._run_script and move script names to ports.py
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-02 04:09 PDT by Patrick R. Gansterer
Modified: 2011-04-02 05:16 PDT (History)
2 users (show)

See Also:

Attachments
Patch (10.97 KB, patch)
2011-04-02 04:14 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2011-04-02 04:09:04 PDT 
Remove AbstractStep._run_script and move script names to ports.py
Comment 1 Patrick R. Gansterer 2011-04-02 04:14:32 PDT 
Created attachment 87974 [details]
Patch
Comment 2 Eric Seidel 2011-04-02 04:48:23 PDT 
Comment on attachment 87974 [details]
Patch

Sigh.  Well, this is a good thing to do, but there are two troubles I should point outin this patch.  1.  ports.py should die.  class methods aren't long-term scaleable.  We have a port.py over in layout_tests which we eventually want to merge it with/replace it with.

Second, run_and_throw_if_fail also is deprecated and should die. :)

That said, this is a great change to get rid of a fixme!

I'm glad to see you workign on webkitpy!
Comment 3 WebKit Commit Bot 2011-04-02 05:15:59 PDT 
Comment on attachment 87974 [details]
Patch

Clearing flags on attachment: 87974

Committed r82771: <http://trac.webkit.org/changeset/82771>
Comment 4 WebKit Commit Bot 2011-04-02 05:16:04 PDT 
All reviewed patches have been landed.  Closing bug.