Bug 57704 – Remove AbstractStep._run_script and move script names to ports.py

Bug 57704 - Remove AbstractStep._run_script and move script names to ports.py


Summary:	Remove AbstractStep._run_script and move script names to ports.py

Status:	RESOLVED FIXED

Product:	WebKit
Component:	New Bugs
Version:	528+ (Nightly build)
Platform:	Other Mac OS X 10.5

Importance:	P2 Normal
Assigned To:	Patrick R. Gansterer

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-04-02 04:09 PST by Patrick R. Gansterer
Modified:	2011-04-02 05:16 PST (History)

Attachments
Patch (10.97 KB, patch) 2011-04-02 04:14 PST, Patrick R. Gansterer	no flags	Review Patch \| Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

Description From Patrick R. Gansterer 2011-04-02 04:09:04 PST

Remove AbstractStep._run_script and move script names to ports.py

------- Comment #1 From Patrick R. Gansterer 2011-04-02 04:14:32 PST -------

Created an attachment (id=87974) [details]
Patch

------- Comment #2 From Eric Seidel 2011-04-02 04:48:23 PST -------

(From update of attachment 87974 [details])
Sigh.  Well, this is a good thing to do, but there are two troubles I should point outin this patch.  1.  ports.py should die.  class methods aren't long-term scaleable.  We have a port.py over in layout_tests which we eventually want to merge it with/replace it with.

Second, run_and_throw_if_fail also is deprecated and should die. :)

That said, this is a great change to get rid of a fixme!

I'm glad to see you workign on webkitpy!

------- Comment #3 From WebKit Commit Bot 2011-04-02 05:15:59 PST -------

(From update of attachment 87974 [details])
Clearing flags on attachment: 87974

Committed r82771: <http://trac.webkit.org/changeset/82771>

------- Comment #4 From WebKit Commit Bot 2011-04-02 05:16:04 PST -------

All reviewed patches have been landed.  Closing bug.